Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v16.1.1 #1464

Merged
merged 14 commits into from
Oct 1, 2024
Merged

v16.1.1 #1464

merged 14 commits into from
Oct 1, 2024

Conversation

nuclearace
Copy link
Member

Fixes for various connection status stuff

@nuclearace
Copy link
Member Author

@WestFlow127 LMK how testing goes

@WestFlow127
Copy link

@WestFlow127 LMK how testing goes

@nuclearace , I pulled the repo, switch to this PR, and ran all tests in TestSocketIO and all passed!
Is there anything else you'd like me to do?

@nuclearace
Copy link
Member Author

@WestFlow127, if you're able, testing against a socket.io server and doing some basic sanity checks would be helpful

@WestFlow127
Copy link

@nuclearace I can do that, we run a socket.io server at my company. I'll test general functionality, various reconnection scenarios, and the timingOut fix.

@WestFlow127
Copy link

Update:

Was able to test general functionality which was good. Testing various reconnects was difficult due to my locations poor 5G service. I want to test on stable/good connections. Will likely do so over the holiday. (@nuclearace )

@mahyarq
Copy link

mahyarq commented Dec 23, 2023

I can see that this version fixes the issue i just reported on #1470
Need any help with getting anything done to prepare this for release? @nuclearace @WestFlow127

@miguelaboliveira
Copy link

Any ETA for this release?

@WestFlow127
Copy link

I have the green light to resume testing this PR during my workday tomorrow.
Going to further test socket reconnects using cellular service with our live socket server.
Stay tuned @nuclearace

@WestFlow127
Copy link

Just finished testing 5G/cellular reconnects and it worked great.
Immediately reconnected to socket upon 5G reconnection.
I believe this PR is good to go, @nuclearace

@WestFlow127
Copy link

More users of this repo are requesting this to be merged: #1375 (comment)

@nuclearace I support merging this as I have tested it against our socket server.

@WestFlow127 WestFlow127 mentioned this pull request Jan 31, 2024
Merged
@xmollv
Copy link

xmollv commented Feb 1, 2024

More users of this repo are requesting this to be merged: #1375 (comment)

@nuclearace I support merging this as I have tested it against our socket server.

Can we get it in? Would solve a big issue we're facing! 🙏🏼 // @nuclearace

@WestFlow127
Copy link

@nuclearace Please read above comments 🙏🏼

elefantel and others added 2 commits March 18, 2024 11:18
@elefantel
Bump minimum deployment target to iOS 12 to match Starscream dependency
eb806b6 
Currently there is an error when compiling for release:
```
Compiling for iOS 11.0, but module 'Starscream' has a minimum deployment target of iOS 12.0
```

This pull request addresses this error by bumping the minimum deployment target to match Starscream.
@nuclearace
Merge pull request #1482 from elefantel/patch-1
d069bbe 
Bump minimum deployment target to iOS 12 to match Starscream dependency
@nuclearace nuclearace marked this pull request as ready for review March 18, 2024 13:11
@Crysis21
Copy link

@nuclearace any updates on the socket.io for swift? This library feels deprecated and it's the only package I've come accross in the socket.io ecosystem that is no longer maintained/working properly.

@xmollv
Copy link

xmollv commented Mar 19, 2024

@nuclearace any updates on the socket.io for swift? This library feels deprecated and it's the only package I've come accross in the socket.io ecosystem that is no longer maintained/working properly.

We have the same question. Both on the server and on Android everything seems to work fine, but on iOS we're constantly battling issues due to the unreliability of this SDK. This PR made it somewhat better, but still seems that there's a ton of room for improvement - yet there doesn't seem to be any active development.

@Crysis21
Copy link

for us and many other people, the swift client doesn't connect in WS mode, only in polling. using latest nodeJS backend and android works flawless. sadly this is not the case with swift.

@nuclearace
Copy link
Member Author

@nuclearace any updates on the socket.io for swift? This library feels deprecated and it's the only package I've come accross in the socket.io ecosystem that is no longer maintained/working properly.

Sorry about this, life has sadly been quite rough this past year and I haven't been able to devote much spare time outside of work and family. I'm hoping to start circle back in the coming months

@nuclearace
Copy link
Member Author

for us and many other people, the swift client doesn't connect in WS mode, only in polling. using latest nodeJS backend and android works flawless. sadly this is not the case with swift.

Looking into this now

@WestFlow127 WestFlow127 mentioned this pull request Apr 15, 2024
Closed
@WestFlow127
Copy link

@nuclearace Things to add to this version:

  • Updated Privacy Manifest
  • Update Starscream to v4.0.8

@hsjcom
Update SocketEngine.swift
354ed7e 
Fix the issue where it takes over 60 seconds to close the socket after a network disconnection, and the problem where the server-side socket takes over 30 seconds to close when the server ends a connection
@neobie
Copy link

neobie commented May 22, 2024

when is this v16.1.1 going to release ?

@EchoLunar
Copy link

Due to issues with Apple's review process, I had to upgrade from 15.x to 16.x recently. During previous tests on 16.x, I encountered various connection status problems, including but not limited to obtaining incorrect statuses. I hope 16.1.1 can be released as soon as possible. I suspect there are many others in a similar situation. Thank you very much for your attention to this matter.

@WestFlow127
Copy link

@nuclearace I think releasing this with Privacy manifest stuff would help a lot people/companies out.

Double back when you're more available to address the other connection issues.

@xmollv
Copy link

xmollv commented Jul 16, 2024

Can we all agree this SDK is no longer maintained? I've been thinking about building my own because of how terrible the experience for our users is, but before I embark in such a quest, I'd like to know for sure if there's any plan to solve the plethora of connection issues that we're all experiencing or not.

@DjalilovGusein
Copy link

Please, fix the issue with reconnection

@ArtemBurmistrov
Copy link

Hey @darrachequesne,
It looks like this repo hasn't been getting much attention lately. A few important fixes are still not merged or reviewed after almost a year, including this PR. Do you think it might be a good idea to add a note in the README saying a new maintainer is needed?
Thanks!

davidkessler-ch added a commit to davidkessler-ch/socket.io-client-swift that referenced this pull request Sep 4, 2024
@davidkessler-ch
manually add the changes of PR of main library: socketio#1464
b00f0b7
@cbiggin cbiggin mentioned this pull request Sep 30, 2024
Open
@nuclearace
Merge pull request #1492 from xxZap/master
b4bff5d 
Support Privacy Manifest: bump Starscream package version to upToNextMajor 4.0.8
@nuclearace
Merge pull request #1491 from hsjcom/master
99b673d 
Fix the issue where it takes over 60 seconds to close the socket after a network disconnection
@nuclearace
Merge pull request #1467 from olejnjak/xcode15
99cc244 
Xcode 15 support
@nuclearace nuclearace merged commit d690d9c into master Oct 1, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.