This repository has been archived by the owner on Mar 26, 2024. It is now read-only.
[WIP] Rails 6 update #402
Open
[WIP] Rails 6 update #402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
To make the tests work at all rspec-rails currently required a prerelease version. The latest one introduced an issue that causes 16 tests to fail though. Linking this here for reference: rspec/rspec-rails#2252 |
ZeroPointEnergy
force-pushed
the
rails6
branch
from
b5f4583 to
067f6c0
Compare
smortex
approved these changes
Jun 28, 2021
| @@ -35,7 +35,7 @@ gem 'ruby-progressbar' | |||
| group :development, :test do | |||
| gem 'mocha' | |||
| gem 'sqlite3' | |||
| gem 'rspec-rails' | |||
| gem 'rspec-rails', '4.0.0.beta2' | |||
There was a problem hiding this comment.
👋 rspec-rails 4 was released. Maybe it's possible to drop the version specification?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just a first attempt to migrate to Rails 6. This is in no way ready for merging, just to share the progress in the (very very unlikely) case someone else wants to work on this as well.