[WIP] Added changes to support and enable installation of SODA on Ubuntu20.04 #486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joseph-v
reviewed
Dec 31, 2021
| @@ -29,38 +29,39 @@ | |||
| get_url: | |||
| url={{ etcd_download_url }} | |||
| dest=/opt/{{ etcd_tarball }} | |||
| when: | |||
There was a problem hiding this comment.
Any reason for changing these ?
There was a problem hiding this comment.
These got changed by mistake. Essentially the same thing but written in one line. I have reverted it in a commit.
joseph-v
reviewed
Dec 31, 2021
| @@ -50,11 +50,13 @@ | |||
| systemd: | |||
| name: soda-etcd | |||
| state: stopped | |||
| when: ansible_distribution == "Ubuntu" and (ansible_lsb.major_release|int >=16 and ansible_lsb.major_release|int <=18) | |||
There was a problem hiding this comment.
Instead of checking OS, can we check a variable to know if etcd is installed as systemd service?
There was a problem hiding this comment.
@joseph-v This is inside the handler. The handler code is invoked from the ansible/roles/cleaner/tasks/main.yml where the condition install_as_systemd == true is checked.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind enhancement
What this PR does / why we need it:
This PR enables the installation of SODA on Ubuntu 20.04.
Which issue(s) this PR fixes:
Fixes #485
Test Report Added?:
/kind TESTED
Test Report:
Tested on Virtual box with Ubuntu 20.04 and Ubuntu 18.04.
Special notes for your reviewer: