fix: isEmpty returning incorrect value

sodiray · Sep 11, 2024 · 83e8ed5 · 83e8ed5
1 parent 72201ac
commit 83e8ed5
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 0 deletions.
diff --git a/src/tests/typed.test.ts b/src/tests/typed.test.ts
@@ -360,6 +360,7 @@ describe('typed module', () => {
       assert.isTrue(_.isEmpty(0))
       assert.isTrue(_.isEmpty(true))
       assert.isTrue(_.isEmpty([]))
+      assert.isTrue(_.isEmpty(0n))
       assert.isTrue(_.isEmpty(false))
       assert.isTrue(_.isEmpty({}))
       assert.isTrue(_.isEmpty(''))
@@ -371,6 +372,7 @@ describe('typed module', () => {
       assert.isFalse(_.isEmpty(new Date()))
       assert.isFalse(_.isEmpty(new Date('2022-09-01T02:19:55.976Z')))
       assert.isFalse(_.isEmpty(22))
+      assert.isFalse(_.isEmpty(1n))
       assert.isFalse(_.isEmpty(new Person()))
       assert.isFalse(_.isEmpty({ name: 'x' }))
       assert.isFalse(_.isEmpty('abc'))

diff --git a/src/typed.ts b/src/typed.ts
@@ -72,6 +72,7 @@ export const isEmpty = (value: any) => {
   if (value === true || value === false) return true
   if (value === null || value === undefined) return true
   if (isNumber(value)) return value === 0
+  if (isBigInt(value)) return value === 0n
   if (isDate(value)) return isNaN(value.getTime())
   if (isFunction(value)) return false
   if (isSymbol(value)) return false