Add correct handling of non string, number or symbol values to unique #343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Hey @jordydhoker thanks for the PR 👍 I'm curious what your use case is? I'm not sure the ability to use non-primitive values as identifies is worth using a map. I think this change could lead to devs 'shooting themselves in the foot' if they have the ability to use any value for the identity/equality. |
aleclarson
added a commit
to radashi-org/radashi
that referenced
this pull request
Jun 23, 2024
Thanks to @jordydhoker for contributing this test: sodiray/radash#343
aleclarson
added a commit
to radashi-org/radashi
that referenced
this pull request
Jun 24, 2024
Thanks to @jordydhoker for contributing this test: sodiray/radash#343
aleclarson
added a commit
to radashi-org/radashi
that referenced
this pull request
Jun 25, 2024
Thanks to @jordydhoker for contributing this test: sodiray/radash#343
aleclarson
added a commit
to radashi-org/radashi
that referenced
this pull request
Jun 25, 2024
* fix(unique): support any value …instead of only values that can be identified through a key or can be used as keys themselves. * test: add a test Thanks to @jordydhoker for contributing this test: sodiray/radash#343 * fix(unique): skip `reduce` call if `toKey` is not defined Co-authored-by: jordydhoker <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The issue should be clear enough: #342
Checklist
package.jsonhas been bumped (matching semver)yarn buildcommand has been run and to update thecdndirectory/docsdirectory) has been updatedResolves #342