Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(object): fixed set not setting keys starting with number correctly #383

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

UnKnoWn-Consortium
Copy link
Contributor

@UnKnoWn-Consortium UnKnoWn-Consortium commented Mar 12, 2024

Description

fix(object): fixed set not setting keys starting with number correctly
test(object): updated test for the set function

Checklist

  • Changes are covered by tests if behavior has been changed or added
  • Tests have 100% coverage
  • If code changes were made, the version in package.json has been bumped (matching semver)
  • If code changes were made, the yarn build command has been run and to update the cdn directory
  • If code changes were made, the documentation (in the /docs directory) has been updated

Resolves

Resolves #357

test(object): updated test for the `set` function
Copy link

vercel bot commented Mar 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
radash-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 12, 2024 3:43am

@aleclarson
Copy link

aleclarson commented Jun 28, 2024

Hi @UnKnoWn-Consortium, your fix is available in radashi@beta today (see #15). An official release is pending. We'd love to have you participate in the discussion and/or development of the radashi-org/radashi fork. 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

set should not use array when object key string start with number
2 participants