Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

types: type safer implementation and more accurate inference of return value type for shake #404

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

AliubYiero
Copy link

Description

  • Type Fix: Fix the problem that the return value of shake() function is always a null object by TypeScript inference.
  • Comment Add: Sample code added to the JsDoc for the shake() function.

Checklist

  • Changes are covered by tests if behavior has been changed or added
  • Tests have 100% coverage
  • If code changes were made, the version in package.json has been bumped (matching semver)
  • If code changes were made, the yarn build command has been run and to update the cdn directory
  • If code changes were made, the documentation (in the /docs directory) has been updated

Resolves

Resolves #388

Copy link

vercel bot commented May 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
radash-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 5, 2024 1:52pm

@aleclarson
Copy link

Hi @AliubYiero, your fix is available in radashi@beta today (see #12). An official release is pending. We'd love to have you participate in the discussion and/or development of the radashi-org/radashi fork. 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants