Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More compile options #154

Merged
merged 3 commits into from
Jan 10, 2025
Merged

Conversation

jacob-hughes
Copy link
Collaborator

This adds the following compile-time options to Alloy:

finalizer_safety_analysis = true
premature_finalizer_prevention_optimize = true

@ltratt ltratt added this pull request to the merge queue Jan 10, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 10, 2025
@jacob-hughes
Copy link
Collaborator Author

jacob-hughes commented Jan 10, 2025

This was still trying to push a finalizer-elision feature flag at bootstrap time but we've now moved this into a rustc -Cno-finalizer-elision flag. Fixed in acf5ed4.

@ltratt
Copy link
Member

ltratt commented Jan 10, 2025

Please squash.

Instead of requiring two distinct builds, finalizer elision can now be
turned on or off for an existing build using the -C flag.
@jacob-hughes
Copy link
Collaborator Author

Squashed

@ltratt ltratt added this pull request to the merge queue Jan 10, 2025
Merged via the queue into softdevteam:master with commit f1ffa67 Jan 10, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants