Switch to using bitflags for FSA #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ltratt
reviewed
Jan 31, 2025
| if self.visited_fns.contains(&instance) { | ||
| // We've already checked this function. Ignore it! | ||
| continue; | ||
| } | ||
| self.visited_fns.insert(instance); | ||
| // if instance.def.get_attrs(self.ecx.tcx, sym::rustc_fsa_safe_fn).next().is_some() { |
There was a problem hiding this comment.
Commented code. Please force push an update.
There was a problem hiding this comment.
Oops. Force-pushed an update
jacob-hughes
force-pushed
the
use_bitflags
branch
from
48bcf8f to
9e639b3
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
Ah that's annoying. These test failures are fixed in my next PR. I only broke it out like this because it was becoming unmanagable. Are you ok if I #ignore them and then immediately fix them in the next one? |
|
Can you just push the necessary commits in here? |
|
I can, but that branch (the FSA intrinsic support) is currently failing 2 of the auto-trait UI tests on bootstrap stage 2. I can push it as part of this PR once I've got them working. |
|
OK, then please force push an update here that |
There are now various combinations of possible checks that FSA can perform which can change dynamically based on previously identified errors (e.g. the discovery of a thread-local means that we no longer check for other things). By passing this around as bit flags it becomes easier to write out the conditional logic.
jacob-hughes
force-pushed
the
use_bitflags
branch
from
9e639b3 to
7d595d8
Compare
|
Force pushed an update |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are now various combinations of possible checks that FSA can perform which can change dynamically based on previously identified errors (e.g. the discovery of a thread-local means that we no longer check for other things). By passing this around as bit flags it becomes easier to write out the conditional logic.