This repository has been archived by the owner on Nov 27, 2023. It is now read-only.
Using proper volume size for volume creating #162
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yes, this ensures the given volume size is always >= the requested volume size. +1 |
|
|
||
| return price_matrix[capacity_idx] | ||
| try: | ||
| # find the closet capacity to the requested size |
There was a problem hiding this comment.
typo here - should be "closest"
There was a problem hiding this comment.
Good eyes ;) , Done.
Correct the logic that used to find the closet capacity to the requested volume size. Without this change, for example, end user even couldn't create an 1GB volume from SL backend by jumpgate. Signed-off-by: Zhi Yan Liu <[email protected]>
|
Sorry, some wrong happened, please check #163 for latest change. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Correct the logic that used to find the closet capacity to the requested
volume size. Without this change, for example, end user even couldn't
create an 1GB volume from SL backend by jumpgate.
Signed-off-by: Zhi Yan Liu [email protected]