New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix stack overflow on display error #43

Open

Aceeri wants to merge 1 commit into softprops:master from Aceeri:error-stackoverflow

Contributor

Aceeri commented Oct 22, 2018

If you did println!("{}", err); it would stack overflow because the Display impl recursively called Display::fmt on itself here


          Fix stack overflow on display error

9215c3e

Aceeri force-pushed the error-stackoverflow branch from b6771cb to 9215c3e Compare

October 22, 2018 23:58

ufoscout commented Dec 22, 2020

This issue is still present in the master branch and it causes a stack overflow if the credentials to connect to Jira are not valid.

Here a simple way to fix it:

change from:

writeln!(f, "Could not connect to Jira: {}!", self),

to:

writeln!(f, "Could not connect to Jira: {:?}!", self),

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet