Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Style transfer #16

Merged
merged 15 commits into from
Aug 21, 2024
Merged

Style transfer #16

merged 15 commits into from
Aug 21, 2024

Conversation

mkopcins
Copy link
Collaborator

No description provided.

@mkopcins mkopcins requested a review from daniel-jodlos August 14, 2024 11:33
Copy link
Collaborator

@daniel-jodlos daniel-jodlos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe we should add some quick tests for the models to make sure that they keep working

lib/ex_vision/style_transfer/style_transfer.ex Outdated Show resolved Hide resolved
Copy link
Collaborator

@daniel-jodlos daniel-jodlos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're still missing tests though. So far we have a pretty good coverage, let's at least add some basic tests for these models.

lib/ex_vision/style_transfer/style_transfer.ex Outdated Show resolved Hide resolved
lib/ex_vision/style_transfer/style_transfer.ex Outdated Show resolved Hide resolved
@mkopcins mkopcins force-pushed the style_transfer branch 3 times, most recently from 79fc97b to 5a5ce43 Compare August 20, 2024 10:57
@daniel-jodlos daniel-jodlos self-requested a review August 20, 2024 12:44
@mkopcins mkopcins merged commit 8b73a2b into main Aug 21, 2024
1 check passed
@mkopcins mkopcins deleted the style_transfer branch August 21, 2024 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants