Skip to content

Commit

Permalink
Cleanup navigation changes
Browse files Browse the repository at this point in the history
  • Loading branch information
WojtekBoman committed Oct 8, 2024
1 parent 53fe13e commit 05d529a
Show file tree
Hide file tree
Showing 10 changed files with 2 additions and 169 deletions.

This file was deleted.

This file was deleted.

2 changes: 1 addition & 1 deletion src/libs/Navigation/Navigation.ts
Original file line number Diff line number Diff line change
Expand Up @@ -26,12 +26,12 @@ import originalGetTopmostReportActionId from './getTopmostReportActionID';
import originalGetTopmostReportId from './getTopmostReportId';
import isReportOpenInRHP from './isReportOpenInRHP';
import linkingConfig from './linkingConfig';
import createSplitNavigator from './linkingConfig/createSplitNavigator';
import linkTo from './linkTo';
import getMinimalAction from './linkTo/getMinimalAction';
import navigationRef from './navigationRef';
import setNavigationActionToMicrotaskQueue from './setNavigationActionToMicrotaskQueue';
import type {NavigationPartialRoute, NavigationStateRoute, RootStackParamList, SplitNavigatorLHNScreen, SplitNavigatorParamListType, State, StateOrRoute} from './types';
import createSplitNavigator from './linkingConfig/createSplitNavigator';

const SPLIT_NAVIGATOR_TO_SIDEBAR_MAP: Record<keyof SplitNavigatorParamListType, SplitNavigatorLHNScreen> = {
[NAVIGATORS.REPORTS_SPLIT_NAVIGATOR]: SCREENS.HOME,
Expand Down
24 changes: 0 additions & 24 deletions src/libs/Navigation/linkingConfig/SEARCH_RHP_SCREENS.ts

This file was deleted.

3 changes: 0 additions & 3 deletions src/libs/Navigation/linkingConfig/getAdaptedStateFromPath.ts
Original file line number Diff line number Diff line change
Expand Up @@ -21,9 +21,6 @@ type GetAdaptedStateReturnType = {

type GetAdaptedStateFromPath = (...args: [...Parameters<typeof getStateFromPath>, shouldReplacePathInNestedState?: boolean]) => GetAdaptedStateReturnType;

type SplitNavigatorLHNScreen = keyof typeof mapLhnToSplitNavigatorName;
type SplitNavigator = (typeof mapLhnToSplitNavigatorName)[SplitNavigatorLHNScreen];

// The function getPathFromState that we are using in some places isn't working correctly without defined index.
const getRoutesWithIndex = (routes: NavigationPartialRoute[]): PartialState<NavigationState> => ({routes, index: routes.length - 1});

Expand Down
50 changes: 0 additions & 50 deletions src/libs/Navigation/newLinkTo/getActionForBottomTabNavigator.ts

This file was deleted.

61 changes: 0 additions & 61 deletions src/libs/Navigation/newLinkTo/index.ts

This file was deleted.

11 changes: 0 additions & 11 deletions src/libs/Navigation/newLinkTo/types.ts

This file was deleted.

3 changes: 0 additions & 3 deletions src/libs/Navigation/types.ts
Original file line number Diff line number Diff line change
Expand Up @@ -60,8 +60,6 @@ type SplitNavigatorParamListType = {
[NAVIGATORS.WORKSPACE_SPLIT_NAVIGATOR]: WorkspaceSplitNavigatorParamList;
};

type SplitNavigatorName = keyof SplitNavigatorParamListType;

type SplitNavigatorByLHN<T extends SplitNavigatorLHNScreen> = (typeof LHN_TO_SPLIT_NAVIGATOR_NAME)[T];

type CentralPaneScreensParamList = {
Expand Down Expand Up @@ -1652,5 +1650,4 @@ export type {
SplitNavigatorLHNScreen,
SplitNavigatorParamListType,
SplitNavigatorByLHN,
SplitNavigatorName,
};
2 changes: 1 addition & 1 deletion src/pages/settings/InitialSettingsPage.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -413,7 +413,7 @@ function InitialSettingsPage({currentUserPersonalDetails}: InitialSettingsPagePr
scrollEventThrottle={16}
contentContainerStyle={[styles.w100]}
showsVerticalScrollIndicator={false}
>
>
{accountMenuItems}
{workspaceMenuItems}
{generalMenuItems}
Expand Down

0 comments on commit 05d529a

Please sign in to comment.