Refactor BackgroundImage, remove unnecessary props

software-mansion-labs · Dec 15, 2023 · 1da3052 · 1da3052
1 parent 09a703d
commit 1da3052
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 10 deletions.
diff --git a/src/pages/GetAssistancePage.js b/src/pages/GetAssistancePage.js
@@ -51,7 +51,6 @@ function GetAssistancePage(props) {
             title: props.translate('getAssistancePage.chatWithConcierge'),
             onPress: () => Report.navigateToConciergeChat(),
             icon: Expensicons.ChatBubble,
-            name: 'Chatbubble',
             shouldShowRightIcon: true,
             wrapperStyle: [styles.cardMenuItem],
         },

diff --git a/src/pages/signin/SignInPageLayout/BackgroundImage/index.ios.js b/src/pages/signin/SignInPageLayout/BackgroundImage/index.ios.js
@@ -1,8 +1,9 @@
 import {Image} from 'expo-image';
 import PropTypes from 'prop-types';
-import React from 'react';
+import React, {useMemo} from 'react';
 import DesktopBackgroundImage from '@assets/images/home-background--desktop.svg';
 import MobileBackgroundImage from '@assets/images/home-background--mobile-new.svg';
+import useStyleUtils from '@hooks/useStyleUtils';
 import useThemeStyles from '@hooks/useThemeStyles';
 import defaultPropTypes from './propTypes';
 
@@ -18,15 +19,13 @@ const propTypes = {
 };
 function BackgroundImage(props) {
     const styles = useThemeStyles();
-    return props.isSmallScreen ? (
-        <Image
-            source={MobileBackgroundImage}
-            style={[styles.signInBackground, {width: props.width}]}
-        />
-    ) : (
+    const StyleUtils = useStyleUtils();
+    const src = useMemo(() => (props.isSmallScreen ? MobileBackgroundImage : DesktopBackgroundImage), [props.isSmallScreen]);
+
+    return (
         <Image
-            source={DesktopBackgroundImage}
-            style={[styles.signInBackground, {width: props.width}]}
+            source={src}
+            style={[styles.signInBackground, StyleUtils.getWidthStyle(props.width)]}
         />
     );
 }