Move the areAllModalsHidden check into shouldAutoFocus of ComposerWit…

…hSuggestion Signed-off-by: Tsaqif <[email protected]>
software-mansion-labs · Jun 5, 2024 · 29992cf · 29992cf
1 parent 961ead8
commit 29992cf
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 6 deletions.
diff --git a/src/components/Modal/BaseModal.tsx b/src/components/Modal/BaseModal.tsx
@@ -141,7 +141,6 @@ function BaseModal(
     };
 
     const handleDismissModal = () => {
-        hideModal();
         ComposerFocusManager.setReadyToFocus(uniqueModalId);
     };
 
@@ -226,7 +225,9 @@ function BaseModal(
                     onBackButtonPress={Modal.closeTop}
                     onModalShow={handleShowModal}
                     propagateSwipe={propagateSwipe}
+                    onModalHide={hideModal}
                     onModalWillShow={saveFocusState}
+                    onDismiss={handleDismissModal}
                     onSwipeComplete={() => onClose?.()}
                     swipeDirection={swipeDirection}
                     isVisible={isVisible}

diff --git a/src/libs/Navigation/AppNavigator/AuthScreens.tsx b/src/libs/Navigation/AppNavigator/AuthScreens.tsx
@@ -154,10 +154,8 @@ const modalScreenListeners = {
     beforeRemove: () => {
         // Clear search input (WorkspaceInvitePage) when modal is closed
         SearchInputManager.searchInput = '';
-        if (Modal.areAllModalsHidden()) {
-            Modal.setModalVisibility(false);
-            Modal.willAlertModalBecomeVisible(false);
-        }
+        Modal.setModalVisibility(false);
+        Modal.willAlertModalBecomeVisible(false);
     },
 };
 

diff --git a/...pages/home/report/ReportActionCompose/ComposerWithSuggestions/ComposerWithSuggestions.tsx b/...pages/home/report/ReportActionCompose/ComposerWithSuggestions/ComposerWithSuggestions.tsx
@@ -46,6 +46,7 @@ import SilentCommentUpdater from '@pages/home/report/ReportActionCompose/SilentC
 import Suggestions from '@pages/home/report/ReportActionCompose/Suggestions';
 import * as EmojiPickerActions from '@userActions/EmojiPickerAction';
 import * as InputFocus from '@userActions/InputFocus';
+import * as Modal from '@userActions/Modal';
 import * as Report from '@userActions/Report';
 import * as User from '@userActions/User';
 import CONST from '@src/CONST';
@@ -285,7 +286,11 @@ function ComposerWithSuggestions(
 
     const parentReportAction = parentReportActions?.[parentReportActionID ?? ''] ?? null;
     const shouldAutoFocus =
-        !modal?.isVisible && isFocused && (shouldFocusInputOnScreenFocus || (isEmptyChat && !ReportActionsUtils.isTransactionThread(parentReportAction))) && shouldShowComposeInput;
+        !modal?.isVisible &&
+        Modal.areAllModalsHidden() &&
+        isFocused &&
+        (shouldFocusInputOnScreenFocus || (isEmptyChat && !ReportActionsUtils.isTransactionThread(parentReportAction))) &&
+        shouldShowComposeInput;
 
     const valueRef = useRef(value);
     valueRef.current = value;