Merge pull request Expensify#37740 from bernhardoj/fix/37708-merchant…

…-required-fields Fix able to confirm split a scan request in policy expense chat even though the merchant is empty
software-mansion-labs · Mar 5, 2024 · 5199604 · 5199604
2 parents 73e96f7 + 9c7e765
commit 5199604
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/src/libs/TransactionUtils.ts b/src/libs/TransactionUtils.ts
@@ -167,7 +167,9 @@ function isCreatedMissing(transaction: Transaction) {
 function areRequiredFieldsEmpty(transaction: Transaction): boolean {
     const parentReport = allReports?.[`${ONYXKEYS.COLLECTION.REPORT}${transaction?.reportID}`] ?? null;
     const isFromExpenseReport = parentReport?.type === CONST.REPORT.TYPE.EXPENSE;
-    return (isFromExpenseReport && isMerchantMissing(transaction)) || isAmountMissing(transaction) || isCreatedMissing(transaction);
+    const isSplitPolicyExpenseChat = !!transaction.comment?.splits?.some((participant) => allReports?.[`${ONYXKEYS.COLLECTION.REPORT}${participant.chatReportID}`]?.isOwnPolicyExpenseChat);
+    const isMerchantRequired = isFromExpenseReport || isSplitPolicyExpenseChat;
+    return (isMerchantRequired && isMerchantMissing(transaction)) || isAmountMissing(transaction) || isCreatedMissing(transaction);
 }
 
 /**