Skip to content

Commit

Permalink
Merge pull request Expensify#29266 from DylanDylann/fix/28952
Browse files Browse the repository at this point in the history
Fix/28952: Add subtitle to category page
  • Loading branch information
puneetlath authored Oct 20, 2023
2 parents bf8b849 + 5511846 commit 70900ae
Show file tree
Hide file tree
Showing 5 changed files with 11 additions and 3 deletions.
1 change: 1 addition & 0 deletions src/languages/en.ts
Original file line number Diff line number Diff line change
Expand Up @@ -584,6 +584,7 @@ export default {
threadRequestReportName: ({formattedAmount, comment}: ThreadRequestReportNameParams) => `${formattedAmount} request${comment ? ` for ${comment}` : ''}`,
threadSentMoneyReportName: ({formattedAmount, comment}: ThreadSentMoneyReportNameParams) => `${formattedAmount} sent${comment ? ` for ${comment}` : ''}`,
tagSelection: ({tagName}: TagSelectionParams) => `Select a ${tagName} to add additional organization to your money`,
categorySelection: 'Select a category to add additional organization to your money',
error: {
invalidAmount: 'Please enter a valid amount before continuing.',
invalidSplit: 'Split amounts do not equal total amount',
Expand Down
1 change: 1 addition & 0 deletions src/languages/es.ts
Original file line number Diff line number Diff line change
Expand Up @@ -578,6 +578,7 @@ export default {
threadRequestReportName: ({formattedAmount, comment}: ThreadRequestReportNameParams) => `Solicitud de ${formattedAmount}${comment ? ` para ${comment}` : ''}`,
threadSentMoneyReportName: ({formattedAmount, comment}: ThreadSentMoneyReportNameParams) => `${formattedAmount} enviado${comment ? ` para ${comment}` : ''}`,
tagSelection: ({tagName}: TagSelectionParams) => `Seleccione una ${tagName} para organizar mejor tu dinero`,
categorySelection: 'Seleccione una categoría para organizar mejor tu dinero',
error: {
invalidAmount: 'Por favor ingresa un monto válido antes de continuar.',
invalidSplit: 'La suma de las partes no equivale al monto total',
Expand Down
4 changes: 3 additions & 1 deletion src/pages/EditRequestCategoryPage.js
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@ import ScreenWrapper from '../components/ScreenWrapper';
import HeaderWithBackButton from '../components/HeaderWithBackButton';
import Navigation from '../libs/Navigation/Navigation';
import useLocalize from '../hooks/useLocalize';
import styles from '../styles/styles';
import Text from '../components/Text';
import CategoryPicker from '../components/CategoryPicker';

const propTypes = {
Expand Down Expand Up @@ -36,7 +38,7 @@ function EditRequestCategoryPage({defaultCategory, policyID, onSubmit}) {
title={translate('common.category')}
onBackButtonPress={Navigation.goBack}
/>

<Text style={[styles.ph5, styles.pv3]}>{translate('iou.categorySelection')}</Text>
<CategoryPicker
selectedCategory={defaultCategory}
policyID={policyID}
Expand Down
4 changes: 3 additions & 1 deletion src/pages/EditRequestTagPage.js
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,9 @@ import PropTypes from 'prop-types';
import Navigation from '../libs/Navigation/Navigation';
import useLocalize from '../hooks/useLocalize';
import ScreenWrapper from '../components/ScreenWrapper';
import Text from '../components/Text';
import HeaderWithBackButton from '../components/HeaderWithBackButton';
import styles from '../styles/styles';
import TagPicker from '../components/TagPicker';

const propTypes = {
Expand Down Expand Up @@ -37,7 +39,7 @@ function EditRequestTagPage({defaultTag, policyID, tagName, onSubmit}) {
title={tagName || translate('common.tag')}
onBackButtonPress={Navigation.goBack}
/>

<Text style={[styles.ph5, styles.pv3]}>{translate('iou.tagSelection', {tagName: tagName || translate('common.tag')})}</Text>
<TagPicker
selectedTag={defaultTag}
tag={tagName}
Expand Down
4 changes: 3 additions & 1 deletion src/pages/iou/MoneyRequestCategoryPage.js
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,8 @@ import CategoryPicker from '../../components/CategoryPicker';
import ONYXKEYS from '../../ONYXKEYS';
import reportPropTypes from '../reportPropTypes';
import * as IOU from '../../libs/actions/IOU';
import styles from '../../styles/styles';
import Text from '../../components/Text';
import {iouPropTypes, iouDefaultProps} from './propTypes';

const propTypes = {
Expand Down Expand Up @@ -70,7 +72,7 @@ function MoneyRequestCategoryPage({route, report, iou}) {
title={translate('common.category')}
onBackButtonPress={navigateBack}
/>

<Text style={[styles.ph5, styles.pv3]}>{translate('iou.categorySelection')}</Text>
<CategoryPicker
selectedCategory={iou.category}
policyID={report.policyID}
Expand Down

0 comments on commit 70900ae

Please sign in to comment.