Rewrote _.each to regular for loop for better async handling

software-mansion-labs · Sep 26, 2023 · 92ef235 · 92ef235
1 parent 1697bb3
commit 92ef235
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 4 deletions.
diff --git a/.github/actions/javascript/authorChecklist/authorChecklist.js b/.github/actions/javascript/authorChecklist/authorChecklist.js
@@ -31,13 +31,14 @@ async function getChecklistCategoriesForPullRequest() {
         per_page: 100,
     });
 
-    _.each(CHECKLIST_CATEGORIES, async ({ detectFunction, items }) => {
+    for (const category of CHECKLIST_CATEGORIES) {
+        const { detectFunction, items } = category;
         const categoryDetected = await detectFunction(changedFiles);
         if (!categoryDetected) {
             return;
         }
         categories.push(items);
-    });
+    };
 
     // TODO add more if statements to look for other dynamic checklist categories
 

diff --git a/.github/actions/javascript/authorChecklist/index.js b/.github/actions/javascript/authorChecklist/index.js
@@ -41,13 +41,14 @@ async function getChecklistCategoriesForPullRequest() {
         per_page: 100,
     });
 
-    _.each(CHECKLIST_CATEGORIES, async ({ detectFunction, items }) => {
+    for (const category of CHECKLIST_CATEGORIES) {
+        const { detectFunction, items } = category;
         const categoryDetected = await detectFunction(changedFiles);
         if (!categoryDetected) {
             return;
         }
         categories.push(items);
-    });
+    };
 
     // TODO add more if statements to look for other dynamic checklist categories