Skip to content

Commit

Permalink
Merge pull request Expensify#50914 from shahinyan11/issues/50316
Browse files Browse the repository at this point in the history
Search - Blue border on the group expense is cut off when the expense is selected
  • Loading branch information
arosiclair authored Oct 29, 2024
2 parents 9d6db1e + 665b815 commit ac4dc92
Show file tree
Hide file tree
Showing 3 changed files with 16 additions and 1 deletion.
1 change: 1 addition & 0 deletions src/CONST.ts
Original file line number Diff line number Diff line change
Expand Up @@ -4239,6 +4239,7 @@ const CONST = {
// The attribute used in the SelectionScraper.js helper to query all the DOM elements
// that should be removed from the copied contents in the getHTMLOfSelection() method
SELECTION_SCRAPER_HIDDEN_ELEMENT: 'selection-scrapper-hidden-element',
INNER_BOX_SHADOW_ELEMENT: 'inner-box-shadow-element',
MODERATION: {
MODERATOR_DECISION_PENDING: 'pending',
MODERATOR_DECISION_PENDING_HIDE: 'pendingHide',
Expand Down
2 changes: 1 addition & 1 deletion src/components/SelectionList/BaseListItem.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ function BaseListItem<TItem extends ListItem>({
role={CONST.ROLE.BUTTON}
hoverDimmingValue={1}
hoverStyle={[!item.isDisabled && styles.hoveredComponentBG, hoverStyle]}
dataSet={{[CONST.SELECTION_SCRAPER_HIDDEN_ELEMENT]: true}}
dataSet={{[CONST.SELECTION_SCRAPER_HIDDEN_ELEMENT]: true, [CONST.INNER_BOX_SHADOW_ELEMENT]: true}}
onMouseDown={(e) => e.preventDefault()}
id={keyForList ?? ''}
style={pressableStyle}
Expand Down
14 changes: 14 additions & 0 deletions web/index.html
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,20 @@
outline: 0;
box-shadow: inset 0px 0px 0px 1px #5AB0FF;
}
:focus-visible[data-inner-box-shadow-element]{
overflow: hidden;
}
:focus-visible[data-inner-box-shadow-element]::before {
content: '';
position: absolute;
top: 0;
left: 0;
right: 0;
bottom: 0;
box-shadow: inset 0px 0px 0px 1px #5AB0FF;
pointer-events: none;
z-index: 1000;
}
:focus[data-focusvisible-polyfill] {
outline: 0;
box-shadow: inset 0px 0px 0px 1px #5AB0FF;
Expand Down

0 comments on commit ac4dc92

Please sign in to comment.