Refactor getChatTabBrickRoad

software-mansion-labs · Feb 1, 2024 · f305cc1 · f305cc1
1 parent 55242e5
commit f305cc1
Showing 1 changed file with 9 additions and 22 deletions.
diff --git a/src/libs/WorkspacesUtils.ts b/src/libs/WorkspacesUtils.ts
@@ -98,32 +98,19 @@ function getChatTabBrickRoad(policyID?: string): BrickRoad | undefined {
 
     let brickRoad: BrickRoad | undefined;
 
-    Object.keys(allReports).forEach((reportID) => {
-        if (brickRoad === CONST.BRICK_ROAD_INDICATOR_STATUS.ERROR) {
-            return;
-        }
-
-        if (policyID && policyID !== allReports?.[reportID]?.policyID) {
-            return;
-        }
-
-        const policyReport = allReports ? allReports[reportID] : null;
+    const policyReports = policyID ? Object.values(allReports).filter((report) => report?.policyID === policyID) : Object.values(allReports);
 
-        if (!policyReport) {
-            return;
-        }
+    const hasChatTabRBR = policyReports.some((report) => report && getBrickRoadForPolicy(report) === CONST.BRICK_ROAD_INDICATOR_STATUS.ERROR);
 
-        const workspaceBrickRoad = getBrickRoadForPolicy(policyReport);
+    if (hasChatTabRBR) {
+        return CONST.BRICK_ROAD_INDICATOR_STATUS.ERROR;
+    }
 
-        if (workspaceBrickRoad === CONST.BRICK_ROAD_INDICATOR_STATUS.ERROR) {
-            brickRoad = CONST.BRICK_ROAD_INDICATOR_STATUS.ERROR;
-            return;
-        }
+    const hasChatTabGBR = policyReports.some((report) => report && getBrickRoadForPolicy(report) === CONST.BRICK_ROAD_INDICATOR_STATUS.INFO);
 
-        if (!brickRoad && workspaceBrickRoad) {
-            brickRoad = workspaceBrickRoad;
-        }
-    });
+    if (hasChatTabGBR) {
+        return CONST.BRICK_ROAD_INDICATOR_STATUS.INFO;
+    }
 
     return brickRoad;
 }