Poc/split adjust to native stack #149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+36
to
+39
| // const bottomTabRoute = getTopmostBottomTabRoute(stateCopy); | ||
| // if (bottomTabRoute?.params && 'policyID' in bottomTabRoute.params) { | ||
| // delete bottomTabRoute.params.policyID; | ||
| // } |
| @@ -1,50 +0,0 @@ | |||
| import type {NavigationAction, NavigationState} from '@react-navigation/native'; | |||
There was a problem hiding this comment.
Let's dig a deep hole for this function :D
Comment on lines
370
to
+389
|
|
||
| // Animation is disabled when navigating to the sidebar screen | ||
| const getSplitNavigatorOptions = (route: RouteProp<AuthScreensParamList>) => { | ||
| if (!shouldUseNarrowLayout || !route?.params) { | ||
| return rootNavigatorOptions.fullScreen; | ||
| } | ||
|
|
||
| const screenName = 'screen' in route.params ? route.params.screen : undefined; | ||
|
|
||
| if (!screenName) { | ||
| return rootNavigatorOptions.fullScreen; | ||
| } | ||
|
|
||
| const animationEnabled = !Object.keys(SIDEBAR_TO_SPLIT).includes(screenName); | ||
|
|
||
| return { | ||
| ...rootNavigatorOptions.fullScreen, | ||
| animation: animationEnabled ? Animations.SLIDE_FROM_RIGHT : Animations.NONE, | ||
| }; | ||
| }; |
There was a problem hiding this comment.
I'll handle it in other PR where I put all nav functions into NavigationUtils
| import type ReactComponentModule from '@src/types/utils/ReactComponentModule'; | ||
|
|
||
| const loadCustomRouter = require<ReactComponentModule>('@libs/Navigation/AppNavigator/createCustomStackNavigator/CustomRouter').default; | ||
| import CustomRouter from './CustomRouter'; | ||
|
|
||
| function useCustomRouterState({state}: CustomStateHookProps) { |
There was a problem hiding this comment.
Let's remember to rename this whole navigator and related functions to root navigator or something else instead of custom stack
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation of Change
Fixed Issues
$
PROPOSAL:
Tests
Offline tests
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop