forked from Expensify/App
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add named params in HybridAppModule methods #151
Closed
war-in
wants to merge
533
commits into
make-new-dot-signin-default-for-hybridapp
from
war-in/add-named-params-to-HybridAppModule-methods
Closed
Add named params in HybridAppModule methods #151
war-in
wants to merge
533
commits into
make-new-dot-signin-default-for-hybridapp
from
war-in/add-named-params-to-HybridAppModule-methods
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: krishna2323 <[email protected]>
Signed-off-by: krishna2323 <[email protected]>
Signed-off-by: krishna2323 <[email protected]>
Signed-off-by: krishna2323 <[email protected]>
Caused by `CONST.UPGRADE_FEATURE_INTRO_MAPPING` returning a new object on each invocation
…isibility conditions
Updating to match existing system message structure
…code-download-stable Add back qr code download feature (with stable version)
Rename Search to Reports
…patch-2 Update en.ts
…/53612 fix: Hide current user in approver selector when 'prevent self approvals' is enabled.
…fix/46897-distance-accountant
…w-report-action-feature-for-search-chat Fix - Web - Search - New messages are not updated automatically in chats section
…-is-not-updated Fix timezone isn't updated on the onyx storage
Reroute to search page for nudge migration
fix: move cursor to end of input on focus
[No QA] Update Accelo-Troubleshooting.md
Skip auto-renew survey for users with no billing history when disabling auto-renew in the Subscription settings
…or-workspace-categories Fix - Checkbox does not appear next to the categories in Categories RHP
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation of Change
Fixed Issues
$
PROPOSAL:
Tests
Offline tests
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop