Enable no-unsafe-call eslint rule
#90
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blazejkustra
requested changes
May 28, 2024
| @@ -32,7 +32,7 @@ const run = () => { | |||
| } | |||
|
|
|||
| if (current.name && current.meanDuration && current.meanCount && timestamp) { | |||
| const formattedName = current.name.split(' ').join('-'); | |||
| const formattedName = (current.name as string).split(' ').join('-'); | |||
There was a problem hiding this comment.
Let's deal with this any type above, current is any too, so focus on this one. Looking at the code I think you should be able to figure out the type 👍
There was a problem hiding this comment.
There is a type in the name of this file
| import type {AnimatedTextInputRef} from '@components/RNTextInput'; | ||
| import type {BaseTextInputRef} from './types'; | ||
|
|
||
| export default function isAnimatedTextInputRef(textInput: React.MutableRefObject<BaseTextInputRef | null>): boolean | null { |
There was a problem hiding this comment.
I think the name of function is a bit misleading, it's more about text input focus state and not if it's animatedTextInput
src/libs/Performance.tsx
Outdated
Comment on lines
92
to
96
| const {default: performance, setResourceLoggingEnabled, PerformanceObserver} = perfModule; | ||
| const perfObserver: new (callback: PerformanceObserverCallback) => PerformanceObserver = PerformanceObserver; | ||
|
|
||
| (setResourceLoggingEnabled as (enabled?: boolean) => void)(true); | ||
| rnPerformance = performance; |
There was a problem hiding this comment.
Let's revert this change and instead fix any as high as possible:
type ReactNativePerformance = {
default: RNPerformance;
setResourceLoggingEnabled: (enabled?: boolean) => void;
PerformanceObserver: typeof RNPerformanceObserver;
};
const perfModule: ReactNativePerformance = require('react-native-performance');…sify-app-fork into ts/enable-no-unsafe-call
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Fixed Issues
$
PROPOSAL:
Tests
Offline tests
QA Steps
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)myBool && <MyComponent />.src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop