Review improvements

CMakeLists.txt

@@ -563,6 +563,12 @@ elseif ("${CMAKE_CXX_COMPILER_ID}" MATCHES "MSVC")
   if (HERMES_MSVC_MP)
     add_definitions( /MP )
   endif()
+
+  # TODO: Investigate disabling strict signed integer overflow for MSVC
+
+  # MSVC does not have strict aliasing so there is no need to support it.
+  # Similar to GCC/Clang above, disable strict signed integer overflow.
+  # append("/d2UndefIntOverflow-" CMAKE_C_FLAGS CMAKE_CXX_FLAGS)
 endif()
 
 # Export a JSON file with the compilation commands that external tools can use

lib/CMakeLists.txt

@@ -177,17 +177,6 @@ if(APPLE AND HERMES_BUILD_APPLE_FRAMEWORK)
     MACOSX_FRAMEWORK_BUNDLE_VERSION ${PROJECT_VERSION}
     MACOSX_FRAMEWORK_IDENTIFIER dev.hermesengine.${HERMES_APPLE_TARGET_PLATFORM}
   )
-  # Install headers into `Headers` while keeping required directory structure
-  set_source_files_properties(${api_headers} PROPERTIES
-    MACOSX_PACKAGE_LOCATION Headers
-  )
-  set_source_files_properties(${api_public_headers} PROPERTIES
-    MACOSX_PACKAGE_LOCATION Headers/Public
-  )
-  if(HERMES_ENABLE_BITCODE)
-    target_compile_options(hermesvm PUBLIC "-fembed-bitcode")
-    target_link_options(hermesvm PUBLIC "-fembed-bitcode")
-  endif()
   # Define the deployment target in the frameworks metadata
   if(HERMES_APPLE_TARGET_PLATFORM MATCHES "iphone")
     add_custom_command(TARGET hermesvm POST_BUILD