Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewrite goto tests to insta #188

Merged
merged 1 commit into from
Jan 17, 2025
Merged

Rewrite goto tests to insta #188

merged 1 commit into from
Jan 17, 2025

Conversation

mkaput
Copy link
Member

@mkaput mkaput commented Jan 15, 2025 •
edited
Loading

Stack:

⚠️ Part of a stack created by spr. Do not merge manually using the UI - doing so may have unexpected results.

@mkaput mkaput requested a review from a team as a code owner January 15, 2025 12:47
@mkaput mkaput requested review from Draggu and integraledelebesgue and removed request for a team January 15, 2025 12:47
This was referenced Jan 15, 2025
Merged
Merged
Merged
Merged
Merged
Merged
Merged
piotmag769
piotmag769 approved these changes Jan 15, 2025
View reviewed changes
Copy link
Contributor

@piotmag769 piotmag769 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I trust that you haven't skipped any tests (won't verify)

tests/e2e/support/insta/mod.rs Show resolved Hide resolved
tests/e2e/goto_definition/enums.rs Show resolved Hide resolved
@mkaput mkaput force-pushed the spr/main/db86574a branch from 0a0556c to 470bd26 Compare January 16, 2025 09:49
@mkaput mkaput force-pushed the spr/main/93c713c0 branch from a7165f2 to 6a0e005 Compare January 16, 2025 09:49
@mkaput mkaput mentioned this pull request Jan 16, 2025
Merged
@mkaput mkaput force-pushed the spr/main/93c713c0 branch from 6a0e005 to 774d299 Compare January 16, 2025 11:55
@mkaput mkaput force-pushed the spr/main/db86574a branch from 470bd26 to e32dca2 Compare January 16, 2025 11:55
@mkaput mkaput force-pushed the spr/main/93c713c0 branch from 774d299 to 7d4527c Compare January 16, 2025 12:13
@mkaput mkaput force-pushed the spr/main/db86574a branch from e32dca2 to c07873e Compare January 16, 2025 12:13
@mkaput mkaput mentioned this pull request Jan 16, 2025
Merged
piotmag769
piotmag769 approved these changes Jan 16, 2025
View reviewed changes
Copy link
Contributor

@piotmag769 piotmag769 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx for adding the test

@mkaput mkaput force-pushed the spr/main/db86574a branch from c07873e to 808672f Compare January 17, 2025 09:32
@mkaput mkaput force-pushed the spr/main/93c713c0 branch from 7d4527c to f1c3b46 Compare January 17, 2025 09:32
@mkaput mkaput force-pushed the spr/main/db86574a branch from 808672f to abfb52d Compare January 17, 2025 09:35
@mkaput mkaput force-pushed the spr/main/93c713c0 branch from f1c3b46 to f1ca571 Compare January 17, 2025 09:35
@mkaput mkaput force-pushed the spr/main/db86574a branch from abfb52d to 9969c35 Compare January 17, 2025 09:44
@mkaput mkaput force-pushed the spr/main/93c713c0 branch 2 times, most recently from e60fe39 to eff1ffa Compare January 17, 2025 09:57
@mkaput mkaput force-pushed the spr/main/db86574a branch from 9969c35 to 41aeca8 Compare January 17, 2025 09:57
@mkaput mkaput force-pushed the spr/main/db86574a branch from 41aeca8 to cc60fa4 Compare January 17, 2025 10:02
@mkaput mkaput force-pushed the spr/main/93c713c0 branch from eff1ffa to bf29e77 Compare January 17, 2025 10:02
@mkaput mkaput force-pushed the spr/main/db86574a branch from cc60fa4 to f0a778a Compare January 17, 2025 10:30
@mkaput mkaput force-pushed the spr/main/93c713c0 branch 2 times, most recently from 18e6d5c to 665eace Compare January 17, 2025 10:46
@mkaput mkaput force-pushed the spr/main/db86574a branch from f0a778a to 22b32e3 Compare January 17, 2025 10:46
Base automatically changed from spr/main/93c713c0 to main January 17, 2025 10:53
@mkaput
Rewrite goto tests to insta
3b961f4 
commit-id:db86574a
@mkaput mkaput force-pushed the spr/main/db86574a branch from 22b32e3 to 3b961f4 Compare January 17, 2025 10:53
@mkaput mkaput added this pull request to the merge queue Jan 17, 2025
Merged via the queue into main with commit 008f758 Jan 17, 2025
11 of 15 checks passed
@mkaput mkaput deleted the spr/main/db86574a branch January 17, 2025 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@integraledelebesgue integraledelebesgue integraledelebesgue approved these changes

@piotmag769 piotmag769 piotmag769 approved these changes

@Draggu Draggu Awaiting requested review from Draggu Draggu is a code owner automatically assigned from software-mansion/cairo-ls

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mkaput @piotmag769 @integraledelebesgue