Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #211

Merged
merged 6 commits into from
Mar 23, 2024
Merged

Update README.md #211

merged 6 commits into from
Mar 23, 2024

Conversation

abuseki
Copy link
Contributor

@abuseki abuseki commented Mar 9, 2024

Add EarthChem

Project name: EarthChem

Project website/repository: https://www.earthchem.org/

License: Five CC licenses are allowed for contributons: CC BY-SA 4.0 recommended and default for submissions of new data sets.
Other CC licenses contributors can choose from: CC BY 4.0, CC BY-NC-SA 4.0, CC BY-NC-SA 3.0 US, CC0.

Submission type: New Data Repository

Checklist for all pull requests:

  • The project is open-source and accessible.
  • Searched the existing entries to make sure this is not a duplicate.
  • Contains only a single addition (make separate PRs if adding more than one).
  • Added the link to the bottom of the relevant category.
  • Created a new category only if necessary.
  • Add icon from the media/icon/ folder if applicable (e.g., ![Python](media/icon/python.png) ).
  • Checked spelling and grammar.
  • Removed trailing whitespace and periods.
  • Confirm the dash – is not a minus -.
  • Used title-casing (AP style) for project name.

Checklist for new software projects:

  • Link the code repository rather than the website/documentation
  • Installation instructions present
  • Documentation looks great
  • Examples or Tutorials to follow
  • Tests and Travis CI running

Checklist for new Data Repositories, Tutorials and Cheat Sheets, and Miscellaneous:

  • Easily accessible
  • Comprehensive and widely appealing

abuseki and others added 4 commits March 9, 2024 17:08
Add EarthChem
Add IsoploR and a new category `geochronology
Add pychron
@mmcint mmcint self-assigned this Mar 22, 2024
@mmcint
Copy link
Contributor

mmcint commented Mar 22, 2024

@abuseki I see that you're adding several links here. are these all associated with earthchem?

@JustinGOSSES we typically try to keep a single project/repo to one commit, correct?

@JustinGOSSES
Copy link
Contributor

Typically one contribution at a time is best. This is because one contribution might not qualify or take longer.

However, probably not worth breaking up this PR once already submitted unless we see a problem with any of the contributions.

I can take the geochron ones as I used the excel addon back in the day and would like to check them out.

Copy link
Contributor

@JustinGOSSES JustinGOSSES left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These all seem good. Cool to see some of the geochron tasks I did in grad school now in a nicer python toolkit.

fix 2 urls that were causing CI to break
Need to add this to the ignore list because they apparently have started to block use of VPNs and other things, which means it fails CI/CD but can still be visited manually if not using VPN.
@JustinGOSSES
Copy link
Contributor

Fixed two URL bugs with issues unrelated to this pull request but that had to be fixed to get CI to pass.

@JustinGOSSES
Copy link
Contributor

Thanks @abuseki and @mmcint

@JustinGOSSES JustinGOSSES merged commit b90c116 into softwareunderground:main Mar 23, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants