Skip to content

Commit

Permalink
manim: relax dependencies and ignore resulting failures in tests
Browse files Browse the repository at this point in the history
This change should only be temporary, as a pull request has already been
merged upstream that relaxes the dependencies [1]. Thus, we just have to
wait for a release containing this pr.

[1]: ManimCommunity/manim#3376

Co-authored-by: dylan madisetti <[email protected]>
  • Loading branch information
soispha and dmadisetti committed Mar 31, 2024
1 parent a7e0f50 commit ac4226f
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 0 deletions.
2 changes: 2 additions & 0 deletions pkgs/applications/video/manim/default.nix
Original file line number Diff line number Diff line change
Expand Up @@ -64,8 +64,10 @@ in python.pkgs.buildPythonApplication rec {

pythonRelaxDeps = [
"cloup"
"isosurfaces"
"pillow"
"skia-pathops"
"watchdog"
];

patches = [
Expand Down
10 changes: 10 additions & 0 deletions pkgs/applications/video/manim/failing_tests.nix
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,16 @@
"test_PointCloudDot"
"test_Torus"

# test_ImplicitFunction[/test_implicit_graph] failing with:
# E AssertionError:
# E Not equal to tolerance rtol=1e-07, atol=1.01
# E Frame no -1. You can use --show_diff to visually show the difference.
# E Mismatched elements: 1185[/633] / 1639680[/1639680] (0.0723[/0.0386]%)
# E Max absolute difference: 125[/121]
# E Max relative difference: 6.5[/1]
"test_ImplicitFunction"
"test_implicit_graph"

# failing with:
# TypeError: __init__() got an unexpected keyword argument 'msg' - maybe you meant pytest.mark.skipif?
"test_force_window_opengl_render_with_movies"
Expand Down

0 comments on commit ac4226f

Please sign in to comment.