Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Borg fixes and balance pass #5218

Merged
merged 12 commits into from
May 5, 2024

Conversation

LongSleeves
Copy link
Contributor

@LongSleeves LongSleeves commented Apr 23, 2024

-Fixes borg panel lock/unlock being flipped in the chat window.
-Fixes borg internal plates not using their actual max_damage
-Replaces engineering borgs krag b gone with space cleaner, krag b gone didn't work and trying to place wires and other things on a gore covered floor was just painful.
-Gives ammo grippers the ability to pick up and place batteries. Laser weapons exist I guess.
-Gives components the ability to have resistances to damage types set. Internal armor plates have various brute and burn resistances based on which mark it is.
-Created new mark 3 robot armor, given to guild crafting tab
-Fixes basic robot armor not showing up in robotics lathe
-Adds mark 5 robot armor to robotics lathe
-Gives ammo grippers the ability to pick up gun parts so some borgs can play with assembling guns.
-Removes embedding from multiple tools and weapons on borgs.
-Nerfs damage on medical borgs laser scalpel (balance request by unit)
-Gives borg hotkeys for pixelshifting
-Makes gold roachlings "neutral" faction so they stop attacking borgs.

-Disables a borg file and deletes a borg file (Told to do so by Coder Cat Trilby)

-Alters borg omni tools to use general coding practices and have a parent pass down values.
-Gives a few borg omni tools qualities that you would expect a robot to be able to perform.
-Gives borg omni tools "sharp" This allows them to cut certain things. Like tower caps into logs.

-Removes the borg version of the chinalake. It was cumbersome to use. And generally not useful on lawed robots that can't use explosives around colony.
-Changes many emag equipment on borgs to be the energy sword instead of things like lube or a breakable pickaxe.

*Basic internal plates are what borgs start with and have the lowest hp with no resistance. * 80 hp with 0% resist.
*Mark 2 has energy and is made at soteria * 120 hp with 50% resist.
*Mark 3 has brute and is made at guild. * 120 hp with 50% resist.
*Mark 5 has no armor but high hp. Its made by both soteria and guild. * 160 hp with 0% resist.

-Removes extra line on robot_damage.dm
-Adjusts borg maxhp to be based off base model and the internal plate inside.
-Allows borgs to be fixed with welders and wires without being open.
-Selecting a borg module will show the max health you would have with your current internal plate.
-Adjusts borg modules HP, This will look MUCH lower due to internal plates adding extra maxHealth now.

  • Baseline : 100 from 200
  • Medical : 120 from 180
  • Engi : 120 from 240
  • Defence : 160 from 180
  • Sec : 220 from 320
  • Jani : 120 from 250
  • Service : 120 from 130
  • Mining : 160 from 250
  • Sci : 120 from 160

-Buffs combat borgs combat related stats.

  • Securitys vigilance : 60 from 0
  • Defences robustness : 60 from 0

-Fixes borg panel lock/unlock being flipped in the chat window. (grammer fix)
-Fixes borg internal plates not having different values based on the plates.
-Gives borgs the ability to have their internal plates fixed with welders (As long as the internal plates are not destroyed, the borg will have to have its panel OPEN for this to be done. This will not work on burn damage. Only brute. Borgs can still not weld themselves. You will have to ask for help.)
-Replaces engineering borgs krag b gone with space cleaner sense krag b gone didn't work and trying to place wires and other things on a gore covered floor was just painful.
-Gives ammo grippers the ability to pick up and place batteries. Laser weapons exist I guess.
-Gives components the ability to have resistances to damage types set. Internal armor plates have various brute and burn resistances based on which mark it is.
basic internal plates are what borgs start with and have the lowest hp with no resistance. You should probably get upgraded from this.
mark 2 has energy and is made at soteria
mark 3 has brute and is made at guild
mark 5 has no armor but high hp. Its made at both.
@LongSleeves
Copy link
Contributor Author

LongSleeves commented Apr 23, 2024

I would take more pictures but its challenging to show things like picking up a cell with a ammo grabber without a video.
Many things were tested and even streamed on soj or shown to Trilby directily. Ontop of the test merge allowing me to get feedback from multiple people.

Picture showing that armour values have their max damage working now. Picture below is showing that it didn't break when taking far more then a basic plates 80 health would be.
variable view
damage without break
Quick picture showing that the space cleaner is in the inventory.
space cleaner
A picture for the robotics lathe fix patch. This picture is before I do any resource costs being adjusted. I need the prices to be semi cheap for testing purposes right now.
armours
Pixel shifting!
break time
Why can't we be friends, why can't we be friends~
blattfriend

@Trilbyspaceclone Trilbyspaceclone added Test Merged A RP that is test merged before added to the code itself Bug-Fix Fixes issues Balance Improves on fairness labels Apr 23, 2024
Fixes bug that runtimes when engineer borg recharges with the space cleaner bottle.
Fixes armor plates not showing up in the lathe correctly after research.
removes extra line on robot_damage.dm
adjusts borg hp to be based off base model and the internal plate inside.
allows borgs to be fixed with welders and wires without being open.
Adjusts borg modules HP, This will look MUCH lower due to internal plates adding extra maxHealth  now.
Baseline : 100 from 200
Medical : 120 from 180
Engi : 120 from 240
Defence : 160 from 180
Sec : 220 from 320
Jani : 120 from 250
Service : 120 from 130
Mining : 160 from 250
Sci : 120 from 160
-Buffs defence borgs robustness and sec borgs vig. It made no sense the combat borgs didn't have these stats at all.
-Alters borg omni tools to use a parent styled layout.
-Gives borg omni tools sharp so they can cut things into planks.
-Unchecks outdated borg files and removes unnecessary file (Trilby requested)
-Allows ammo grippers to pick up gun parts
-Removes embedding from multiple tools and weapons across all borgs.
-Nerfs the damage on the medical borgs scalpel.
-Gives borgs hotkeys for pixelshifting
-Removes defence modules grenade launcher. Explosives can't legally be used in colony.
-Changes out more useless emag equipment to instead be the energy sword.
-Makes gold roachlings neutral faction so they stop attacking borgs.
-Gives sheet loader gripper to miner borg so they can trade materials across desks.
@cdb-is-not-good
Copy link
Collaborator

cdb-is-not-good commented May 5, 2024

Is this good and ready?

@cdb-is-not-good cdb-is-not-good removed the Test Merged A RP that is test merged before added to the code itself label May 5, 2024
@cdb-is-not-good cdb-is-not-good merged commit 92c99a7 into sojourn-13:master May 5, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Balance Improves on fairness Bug-Fix Fixes issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants