fix: use correct config option for @nx/dependency-checks eslint rule

solana-developers · Jul 2, 2024 · b464c1f · b464c1f
1 parent 7573ec9
commit b464c1f
Show file tree

Hide file tree

Showing 10 changed files with 39 additions and 25 deletions.
diff --git a/packages/create-solana-dapp/.eslintrc.json b/packages/create-solana-dapp/.eslintrc.json
@@ -28,7 +28,7 @@
         "@nx/dependency-checks": [
           "error",
           {
-            "buildTargets": ["build-base"],
+            "buildTargets": ["build"],
             "ignoredDependencies": ["nx"]
           }
         ]

diff --git a/packages/create-solana-dapp/lib/final-note.ts b/packages/create-solana-dapp/lib/final-note.ts
@@ -1,4 +1,4 @@
-import { bold, greenBright, magentaBright, yellowBright } from 'chalk'
+import { bold, green, magenta, yellow } from 'picocolors'
 import { GetArgsResult } from './get-args-result'
 import { validateAnchorVersion } from './validate-anchor-version'
 
@@ -17,19 +17,19 @@ export function finalNote(args: GetArgsResult & { target: string }): string {
     if (!version) {
       lines.push(
         ...[
-          bold(yellowBright(`Could not find Anchor version. Please install Anchor.`)),
+          bold(yellow(`Could not find Anchor version. Please install Anchor.`)),
           'https://www.anchor-lang.com/docs/installation',
         ],
       )
     } else if (!valid) {
       lines.push(
         ...[
-          yellowBright(`Found Anchor version ${version}. Expected Anchor version ${requiredVersion}.`),
+          yellow(`Found Anchor version ${version}. Expected Anchor version ${requiredVersion}.`),
           'https://www.anchor-lang.com/release-notes/0.30.0',
         ],
       )
     } else {
-      lines.push(greenBright(`Found Anchor version ${version}. Great!`))
+      lines.push(green(`Found Anchor version ${version}. Great!`))
     }
   }
   return lines.join('\n\n')
@@ -51,5 +51,5 @@ function cmd(pm: string, command: string) {
 }
 
 function msg(message: string) {
-  return bold(magentaBright(message))
+  return bold(magenta(message))
 }
diff --git a/packages/create-solana-dapp/package.json b/packages/create-solana-dapp/package.json
@@ -4,12 +4,13 @@
   "description": "Get up and running fast with Solana dApps",
   "dependencies": {
     "@clack/prompts": "^0.7.0",
-    "@nx/devkit": "19.0.0",
+    "@nx/devkit": "19.3.2",
     "commander": "^11.1.0",
     "create-nx-workspace": "19.0.0",
     "nx": "19.0.0",
-    "tmp": "0.2.1",
-    "tslib": "^2.3.0"
+    "tslib": "^2.3.0",
+    "tmp": "0.2.3",
+    "picocolors": "1.0.0"
   },
   "type": "commonjs",
   "main": "./src/index.js",

diff --git a/packages/preset-anchor/.eslintrc.json b/packages/preset-anchor/.eslintrc.json
@@ -35,7 +35,7 @@
         "@nx/dependency-checks": [
           "error",
           {
-            "buildTargets": ["build-base"],
+            "buildTargets": ["build"],
             "ignoredDependencies": ["@nx/jest"]
           }
         ]

diff --git a/packages/preset-anchor/package.json b/packages/preset-anchor/package.json
@@ -3,8 +3,8 @@
   "version": "0.0.1",
   "description": "This library is a preset for create-solana-dapp that adds anchor support to your project.",
   "dependencies": {
-    "@nx/devkit": "19.0.0",
-    "@nx/js": "19.0.0",
+    "@nx/devkit": "19.3.2",
+    "@nx/js": "^19.3.2",
     "@nx/jest": "19.0.0",
     "@solana-developers/preset-common": "*",
     "@solana/web3.js": "^1.90.0",

diff --git a/packages/preset-next/.eslintrc.json b/packages/preset-next/.eslintrc.json
@@ -35,7 +35,7 @@
         "@nx/dependency-checks": [
           "error",
           {
-            "buildTargets": ["build-base"],
+            "buildTargets": ["build"],
             "ignoredDependencies": ["@nx/jest", "prettier"]
           }
         ]

diff --git a/packages/preset-next/package.json b/packages/preset-next/package.json
@@ -3,16 +3,16 @@
   "version": "0.0.1",
   "description": "This library is a preset for create-solana-dapp that adds next.js support to your project.",
   "dependencies": {
-    "@nx/devkit": "19.0.0",
+    "@nx/devkit": "19.3.2",
     "@nx/jest": "19.0.0",
-    "@nx/js": "19.0.0",
-    "@nx/eslint": "19.0.0",
-    "@nx/next": "19.0.0",
-    "@solana-developers/preset-anchor": "*",
+    "@nx/js": "^19.3.2",
+    "@nx/eslint": "19.3.2",
+    "@nx/next": "19.3.2",
     "@solana-developers/preset-common": "*",
     "@solana-developers/preset-react": "*",
     "prettier": "^2.6.2",
-    "tslib": "^2.3.0"
+    "tslib": "^2.3.0",
+    "@solana/web3.js": "^1.91.9"
   },
   "type": "commonjs",
   "main": "./src/index.js",

diff --git a/packages/preset-react/.eslintrc.json b/packages/preset-react/.eslintrc.json
@@ -35,7 +35,7 @@
         "@nx/dependency-checks": [
           "error",
           {
-            "buildTargets": ["build-base"],
+            "buildTargets": ["build"],
             "ignoredDependencies": ["@nx/webpack", "prettier"]
           }
         ]

diff --git a/packages/preset-react/package.json b/packages/preset-react/package.json
@@ -3,15 +3,16 @@
   "version": "0.0.1",
   "description": "This library is a preset for create-solana-dapp that adds React support to your project.",
   "dependencies": {
-    "@nx/devkit": "19.0.0",
-    "@nx/js": "19.0.0",
-    "@nx/eslint": "19.0.0",
-    "@nx/react": "19.0.0",
+    "@nx/devkit": "19.3.2",
+    "@nx/js": "^19.3.2",
+    "@nx/eslint": "19.3.2",
+    "@nx/react": "19.3.2",
     "@nx/webpack": "19.0.0",
     "@solana-developers/preset-anchor": "*",
     "@solana-developers/preset-common": "*",
     "prettier": "^2.6.2",
-    "tslib": "^2.3.0"
+    "tslib": "^2.3.0",
+    "@solana/web3.js": "^1.91.9"
   },
   "type": "commonjs",
   "main": "./src/index.js",

diff --git a/packages/solana-dev/.eslintrc.json b/packages/solana-dev/.eslintrc.json
@@ -20,6 +20,18 @@
       "rules": {
         "@nx/dependency-checks": "error"
       }
+    },
+    {
+      "files": ["./package.json"],
+      "parser": "jsonc-eslint-parser",
+      "rules": {
+        "@nx/dependency-checks": [
+          "error",
+          {
+            "buildTargets": ["build"]
+          }
+        ]
+      }
     }
   ]
 }