Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add basics/close-account/poseidon #143

Merged
merged 4 commits into from
Jan 2, 2025
Merged

Conversation

ved08
Copy link
Contributor

@ved08 ved08 commented Oct 19, 2024

Added close account example in Poseidon

@jacobcreech
Copy link
Contributor

@ved08 please do not ping maintainers. We will get to these today.

@heyAyushh heyAyushh added contribute:poseidon Adds a poseidon example contribution to the repository. close-account basics/close-account labels Nov 5, 2024
Copy link
Member

@heyAyushh heyAyushh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your submission! To verify the technical implementation, please complete these steps:

  1. Merge the main branch into your PR to get the latest updates
  2. Run pnpm fix at the project root for consistent code style
  3. Ensure your implementation includes:
    • Transpiled Anchor program in the programs folder
    • TypeScript files in the ts-programs folder
  4. Run poseidon sync to synchronize program ID and keys
  5. Run cargo fmt and cargo clippy for Rust code quality
  6. Push your changes

Please note: This review is to verify technical completeness of the submission

Let me know once you've completed these steps and I'll review again. Thanks!

@ved08
Copy link
Contributor Author

ved08 commented Nov 25, 2024

Hey @heyAyushh. I have completed the steps as you instructed. Kindly review it. Thanks!

@heyAyushh heyAyushh merged commit e9546f3 into solana-developers:main Jan 2, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
close-account basics/close-account contribute:poseidon Adds a poseidon example contribution to the repository.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants