Update deserialize instruction data #365
Conversation
…ressSync The signature '(seeds: (Buffer | Uint8Array)[], programId: PublicKey): Promise<[PublicKey, number]>' of 'web3.PublicKey.findProgramAddress' is deprecated. Updated the code to use the recommended 'findProgramAddressSync' method for better compatibility.
…@solana/web3.js instead of importing the entire package. - Replaced .then() with await for better readability and async handling. - Applied linting to maintain code consistency and clarity. - Replaced abbreviations like tx with more descriptive variable names for better code readability. - Enhanced error handling using trycatch.
… included the application screenshot
| @@ -599,8 +599,7 @@ address, you can generate a new program ID from the playground before deploying. | |||
| You can test your program by submitting a transaction with the right instruction | |||
| data. For that, feel free to use | |||
| [this script](https://github.com/Unboxed-Software/solana-movie-client) or | |||
| [the frontend](https://github.com/Unboxed-Software/solana-movie-frontend) we | |||
| built in the | |||
| [the frontend](https://github.com/EmekaManuel/movie-review-dapp) we built in the | |||
There was a problem hiding this comment.
Update this link to use solana-developer/movie-review-frontend
There was a problem hiding this comment.
Update this link to use solana-developer/movie-review-frontend
updated ✅
| @@ -269,7 +282,7 @@ submit a movie review and have it stored on Solana’s network. We’ll build th | |||
| app a little bit at a time over the next few lessons, adding new functionality | |||
| each lesson. | |||
|
|
|||
|  | |||
|  | |||
There was a problem hiding this comment.
Just move this to /public/assets/courses/movie-review-frontend-dapp.png
| @@ -546,7 +575,7 @@ successful. | |||
|
|
|||
| If you need a bit more time with this project to feel comfortable, have a look | |||
| at the complete | |||
| [solution code](https://github.com/Unboxed-Software/solana-movie-frontend/tree/solution-serialize-instruction-data). | |||
| [solution code](https://github.com/EmekaManuel/movie-review-dapp/tree/solution-serialize-instruction-data). | |||
| alert(JSON.stringify(e)); | ||
| console.log(`Transaction submitted: ${explorerLink}`); | ||
| } catch (error) { | ||
| alert(JSON.stringify(error)); |
There was a problem hiding this comment.
No need for JSON stringify and per CONTRIBUTING.md you are allowed to assume anything thrown is an error.
catch (thrownObject) {
const error = thrownObject as Error
alert(error.message)
}
… links. removed unnecessary imports too
…ize-instruction-data
|
@EmekaManuel #365 and #359 both have updates to Please submit a (as in, one) PR for the lesson you are changing, as mentioned in the Superteam Earn bountySome people have submitted a single PR for multiple lessons, which isn't ideal (since they may win one and not win the other) but if one person submits multiple PRs for the same lesson it creates overlap in my work. I have already marked you as the winner for serialize-instruction-data-frontend.md in #359. You cannot win multiple times for the same lesson. I have 70 PRs to review. Submitting multiple entries for the same lesson completely breaks my workflow which is based around there not being overlap in the PRs. Please let me know:
|
Kindly disregard this pull request to avoid complications. I have created a new pull request which only changes the |
|
Closing as requested. |
Problem
outdated movie review frontend app still being referenced
Summary of Changes