Update hello-world-program.md #425
Conversation
Problem - Grammatical mistakes - The dependencies and client code needed updates to ensure compatibility with the latest versions and best practices. Summary of Changes - Fixed grammatical mistakes - Rephrase some words to make them sound more fluent and easier to read. - Added a tutorial video for a visual walkthrough. - Updated instructions for installing dependencies and running the client code. - Updated dependencies and client code ( Unboxed-Software/solana-hello-world-client#6 )
|
Thanks @darkvallen ! I want to let you know there's another, much larger PR for this lesson that's been submitted by someone else already, however we're very grateful for these changes - I'll review this PR shortly. |
nickfrosty
requested review from
mikemaccana
and removed request for
nickfrosty
| - A program processes an instruction using the **program_id**, a list of | ||
| **accounts**, and **instruction_data** included with the instruction |
There was a problem hiding this comment.
| - A program processes an instruction using the **program_id**, a list of | |
| **accounts**, and **instruction_data** included with the instruction | |
| - A program processes an instruction using the **program_id**, a set of named | |
| **accounts**, and **instruction_data** included with the instruction |
| @@ -73,7 +71,7 @@ following structure: | |||
|
|
|||
| The path to `AccountInfo` would be `solana_program::account_info::AccountInfo`. | |||
|
|
|||
| Absent of any other keywords, we would need to reference this entire path to use | |||
| Absent any other keywords, we would need to reference this entire path to use | |||
There was a problem hiding this comment.
| Absent any other keywords, we would need to reference this entire path to use | |
| Without any `use` keywords, we would need to reference this entire path to use |
| is to build our Solana program, so we’ve gone ahead and provided | ||
| [the client code to invoke our “Hello, world!” program](https://github.com/Unboxed-Software/solana-hello-world-client) | ||
| for you to download. | ||
| In this final step, we'll invoke the "Hello, world!" Solana program from the client side. While the main focus of this lesson is on building your Solana program, we've provided [the client code](https://github.com/Unboxed-Software/solana-hello-world-client) to help you easily interact with your deployed program. |
There was a problem hiding this comment.
Moved to https://github.com/solana-developers/hello-world-client - can you please make your updates there instead and fix these links?
|  | ||
|
|
There was a problem hiding this comment.
Video is a good idea. The quality of the video is bad and there seems to be no sound - want to re-record and add a voiceover?
Then contact me via telegram or twitter and send me the raw video for upload to our YouTube channel.
| @@ -14,39 +14,39 @@ description: "Use durable nonces to sign transactions ahead of time." | |||
| have an expiration date of 150 blocks (~80-90 seconds). | |||
There was a problem hiding this comment.
@darkvallen you also have #450 which is for durable-nonces.md. It makes it very difficult for us to track your work when this happens.
Please put all your changes to durable-nonces.md in that PR and remove it from this PR.
There was a problem hiding this comment.
Fixed.
#450 Ready for further review.
|
This pull request has been automatically marked as stale because it has not had recent activity. Remove stale label or comment or this will be closed in 7 days. |
Problem
Summary of Changes
Fixes #
Unboxed-Software/solana-hello-world-client#6