Fix: toggle theme issue (#128) on developers/courses page #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@anas-netixsol is attempting to deploy a commit to the Solana Foundation Team on Vercel. A member of the Team first needs to authorize it. |
catalinred
requested changes
Dec 13, 2024
There was a problem hiding this comment.
Thank you @AnasJMirza for working on this. Good catch!
Can you revert the yarn.lock and package.json changes?
|
@catalinred Yes sure, I am on it! |
|
@AnasJMirza you still willing to wrap this up? |
|
Please merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When toggling between dark and light themes on the Courses Page, the page headings fail to adjust their color. This results in the headings being invisible in light mode after toggling from dark mode.
Summary of Changes
Updated the DevelopersHeroSection.module.scss file to dynamically update heading color of this page. used variable that is already used in the project for theming.
Verified that the headings are now visible in both light and dark modes after toggling the theme.
Code Snippet Highlight:
The current behavior
Fixes #128