SIMD-118: update feature-gate info #171
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry to bother you @lheeger-jump . @topointon-jump approved this via DM, but it looks like he doesn't have a role on this repo in order to officially approve. |
topointon-jump
approved these changes
Nov 3, 2024
You shouldn't need any special role for reviewing. |
CriesofCarrots
force-pushed
the
simd-118-feature
branch
from
c5946c5
to
b6dd5bd
Compare
@Benhawkins18 , I think a user needs to have triage permissions to count as the one required reviewer. (I can't select Tom in the reviewers panel.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testnet exposed a bug in the SIMD-118 implementation. That has been patched (to be released in Agave v2.0.9), and wrapped in a new superset feature gate. This PR updates the feature-gate details. The linked Agave feature issue retains the original feature ID.