SIMD-0174: SBPF arithmetics improvements #174
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lichtso
force-pushed
the
sbpf-arithmetics-improvements
branch
from
a0328f7
to
42ba0ff
Compare
LucasSte
reviewed
Sep 9, 2024
topointon-jump
approved these changes
Nov 1, 2024
Comment on lines
+16
to
+17
| This proposal introduces wide multiplication, signed division and explicit sign | ||
| extension to SBPF. |
There was a problem hiding this comment.
Let's specify which SBPF version this will be released in.
0x0ece
approved these changes
Nov 22, 2024
0x0ece
approved these changes
Nov 22, 2024
|
|
||
| A new instruction class product, quotient and remainder (PQR) is introduced: | ||
|
|
||
| - the `UHMUL64` instruction (opcode `0x36` and `0x3E`) produces the 64 MSBs of |
There was a problem hiding this comment.
Just an impl note for UHMUL64_IMM: imm is sign extended to 64-bits.
Practically speaking, this means that to do 64x64=128 bit umul one should use UHMUL64_REG.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.