Skip to content
This repository has been archived by the owner on Jan 10, 2025. It is now read-only.

token-group: create example program #5548

Merged
merged 6 commits into from
Oct 20, 2023
Merged

token-group: create example program #5548

merged 6 commits into from
Oct 20, 2023

Conversation

buffalojoec
Copy link
Contributor

@buffalojoec buffalojoec commented Oct 16, 2023 •
edited
Loading

This PR adds an example program for the SPL Token Group interface.

It demonstrates using the interface to create a program that can manage token collections - such as NFT Collections!

However, this example does not make use of token metadata, to keep the demonstration simple.

@buffalojoec buffalojoec mentioned this pull request Oct 16, 2023
Merged
@buffalojoec Graphite App
Copy link
Contributor Author

buffalojoec commented Oct 16, 2023 •
edited
Loading

Current dependencies on/for this PR:

This comment was auto-generated by Graphite.

@buffalojoec buffalojoec mentioned this pull request Oct 16, 2023
Closed
@buffalojoec buffalojoec force-pushed the token-group-interface-1 branch from dfa3dd8 to 3185a0e Compare October 17, 2023 14:56
@buffalojoec buffalojoec force-pushed the 10-16-token-group_create_collections_example branch from 407c79c to 4515e06 Compare October 17, 2023 14:56
@buffalojoec buffalojoec marked this pull request as ready for review October 17, 2023 14:57
@buffalojoec buffalojoec force-pushed the token-group-interface-1 branch from 3185a0e to 6d3b1af Compare October 17, 2023 19:54
@buffalojoec buffalojoec force-pushed the 10-16-token-group_create_collections_example branch from 4515e06 to 2dde6b7 Compare October 17, 2023 19:55
joncinque
joncinque reviewed Oct 17, 2023
View reviewed changes
Copy link
Contributor

@joncinque joncinque left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! Mainly small points, but this should be ready soon.

Edit: oh, and be sure to add the new example program to CI

token-group/example/src/processor.rs Outdated Show resolved Hide resolved
token-group/example/src/processor.rs Outdated Show resolved Hide resolved
token-group/example/src/processor.rs Outdated Show resolved Hide resolved
token-group/example/src/processor.rs Outdated Show resolved Hide resolved
token-group/example/src/processor.rs Outdated Show resolved Hide resolved
token-group/example/src/processor.rs Outdated Show resolved Hide resolved
token-group/example/src/processor.rs Outdated Show resolved Hide resolved
token-group/example/tests/setup.rs Outdated Show resolved Hide resolved
token-group/example/tests/update_collection_max_size.rs Outdated Show resolved Hide resolved
@buffalojoec buffalojoec force-pushed the token-group-interface-1 branch from 6d3b1af to 701b548 Compare October 18, 2023 10:23
@buffalojoec buffalojoec force-pushed the 10-16-token-group_create_collections_example branch 2 times, most recently from 773d3a3 to e4e2745 Compare October 18, 2023 11:21
@buffalojoec buffalojoec force-pushed the token-group-interface-1 branch from 701b548 to 1315e99 Compare October 18, 2023 11:56
@buffalojoec buffalojoec force-pushed the 10-16-token-group_create_collections_example branch from e4e2745 to d5a7a7f Compare October 18, 2023 11:56
@buffalojoec buffalojoec force-pushed the token-group-interface-1 branch from 1315e99 to eecc418 Compare October 18, 2023 12:16
@buffalojoec buffalojoec force-pushed the 10-16-token-group_create_collections_example branch from d5a7a7f to 928093f Compare October 18, 2023 12:18
This was referenced Oct 18, 2023
Closed
Closed
Closed
Merged
Base automatically changed from token-group-interface-1 to master October 18, 2023 16:32
@buffalojoec buffalojoec changed the title token-group: create collections example token-group: create example program Oct 18, 2023
@buffalojoec buffalojoec force-pushed the 10-16-token-group_create_collections_example branch 2 times, most recently from c46f300 to 946b876 Compare October 19, 2023 11:56
@buffalojoec buffalojoec requested a review from joncinque October 19, 2023 14:39
@buffalojoec buffalojoec mentioned this pull request Oct 19, 2023
Merged
@buffalojoec buffalojoec force-pushed the 10-16-token-group_create_collections_example branch 2 times, most recently from c2a8050 to d2916be Compare October 20, 2023 07:26
@buffalojoec buffalojoec changed the base branch from master to 10-20-token_group_add_mint_to_interface October 20, 2023 07:45
@buffalojoec buffalojoec force-pushed the 10-16-token-group_create_collections_example branch from d2916be to 052500a Compare October 20, 2023 07:45
@buffalojoec buffalojoec mentioned this pull request Oct 20, 2023
Merged
@buffalojoec buffalojoec force-pushed the 10-20-token_group_add_mint_to_interface branch from a842cc8 to 719c597 Compare October 20, 2023 08:57
@buffalojoec buffalojoec force-pushed the 10-16-token-group_create_collections_example branch from 052500a to 8531594 Compare October 20, 2023 08:57
Base automatically changed from 10-20-token_group_add_mint_to_interface to master October 20, 2023 10:10
@buffalojoec buffalojoec force-pushed the 10-16-token-group_create_collections_example branch from 8531594 to 2ce7dd4 Compare October 20, 2023 10:54
@buffalojoec buffalojoec mentioned this pull request Oct 20, 2023
Merged
joncinque
joncinque reviewed Oct 20, 2023
View reviewed changes
Copy link
Contributor

@joncinque joncinque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly small things, this is very close to ready!

.github/workflows/pull-request-token-group.yml Outdated Show resolved Hide resolved
token-group/example/Cargo.toml Outdated Show resolved Hide resolved
token-group/example/src/lib.rs Show resolved Hide resolved
token-group/example/src/lib.rs Outdated Show resolved Hide resolved
token-group/example/src/processor.rs Show resolved Hide resolved
token-group/example/tests/initialize_member.rs Outdated Show resolved Hide resolved
@buffalojoec
Copy link
Contributor Author

Alright, addressed!

joncinque
joncinque approved these changes Oct 20, 2023
View reviewed changes
Copy link
Contributor

@joncinque joncinque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, nice job!

@buffalojoec buffalojoec merged commit 245f9a2 into master Oct 20, 2023
@buffalojoec buffalojoec deleted the 10-16-token-group_create_collections_example branch October 20, 2023 13:48
This was referenced Oct 21, 2023
Merged
Merged
Merged
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@joncinque joncinque joncinque approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@buffalojoec @joncinque