Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added "Edit this page" link to docs #5905

Closed

Conversation

daertommy
Copy link

With this PR readers can suggest changes to the docs with an easy to use WYSIWYG markdown editor.

This is how the editor looks like for this repo.

holocron-docusaurus-demo.mp4

@mergify mergify bot added the community Community contribution label Nov 28, 2023
@buffalojoec
Copy link
Contributor

This is really cool! Would we need to add any applications to the repository with permissions of some sort?

@daertommy
Copy link
Author

No need for a GitHub app, it fetches the files with the GitHub API and given this repo is public you don't need to install anything

Holocron also has a GitHub integration to push changes directly into a branch instead of opening a PR in case you want to try that too 😀

@buffalojoec
Copy link
Contributor

I love it, but it seems to be taking a looong time to load for me.

@daertommy
Copy link
Author

Does it take a long time after clicking the "open pr" button? or just loading the website?

@buffalojoec
Copy link
Contributor

I got it to load after a refresh.

This is a really cool feature, and I appreciate you PR'ing this into the library. However, I don't want to add this feature yet. We will likely give the docs a makeover and we don't want to confuse contributors with the multiple auth steps and routing to a web editor.

I'll be sure to surface this PR whenever we revisit the docs stuff!

@daertommy
Copy link
Author

Ok, thank your for giving me some feedback!

@daertommy daertommy closed this Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community Community contribution
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants