This repository has been archived by the owner on Jan 10, 2025. It is now read-only.
Extract spl-math-utils from spl-math #7421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinheavey
force-pushed
the
extract-math-utils
branch
from
cef655b to
898598b
Compare
|
Clippy errors are unrelated to this PR: |
kevinheavey
force-pushed
the
extract-math-utils
branch
from
898598b to
af11bcb
Compare
joncinque
reviewed
Oct 31, 2024
libraries/math-utils/Cargo.toml
Outdated
| @@ -0,0 +1,19 @@ | |||
| [package] | |||
| name = "spl-math-utils" | |||
There was a problem hiding this comment.
Can we have this crate be spl-math and change the one with the program to spl-math-example?
There was a problem hiding this comment.
Done. Set the spl-math version back to 0.3 and set spl-math-example version to 0.1
joncinque
added a commit
to joncinque/solana-program-library
that referenced
this pull request
Nov 20, 2024
#### Problem The current spl-stake-pool crate doesn't always work due to its dependency on spl-math which still uses the v1 Solana crates. #### Summary of changes Since the spl-math dependency wasn't actually needed, it was removed in solana-labs#7421. So just to get a new patch release out, downgrade the local dependencies. This will fail CI, but after it lands we can tag the release, and revert this PR.
joncinque
added a commit
that referenced
this pull request
Nov 20, 2024
#### Problem The current spl-stake-pool crate doesn't always work due to its dependency on spl-math which still uses the v1 Solana crates. #### Summary of changes Since the spl-math dependency wasn't actually needed, it was removed in #7421. So just to get a new patch release out, downgrade the local dependencies. This will fail CI, but after it lands we can tag the release, and revert this PR.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Crates that are using
spl-mathas a library don't need the parts that usesolana_program.This PR pulls the math parts into a separate
spl-math-utilscrate and updatesspl-token-swapto use that instead ofspl-math. That's the only SPL crate that usesspl-math.This PR also removes
spl-mathfrom thespl-stake-pooldeps butspl-stake-poolwasn't usingspl-mathin the first place