Skip to content
This repository has been archived by the owner on Jan 22, 2025. It is now read-only.

explorer: revert original asset links for NFTs due to prettier issue #20748

Closed

Conversation

oJshua
Copy link
Contributor

@oJshua oJshua commented Oct 17, 2021

Problem

Prettier is taking issue with the changes in this commit: https://github.com/solana-labs/solana/pull/20709/files
Somehow it got through CI the first pass.

Summary of Changes

Revert commit for now.

Fixes #

@oJshua
Copy link
Contributor Author

oJshua commented Oct 17, 2021

@roederw Looks like we might be having a deeper CI issue. I'll see if @jstarry has any ideas.

@carllin
Copy link
Contributor

carllin commented Oct 17, 2021

It is always checking out master before running the formatter?
master

@carllin
Copy link
Contributor

carllin commented Oct 17, 2021

image

Will something like this use the pull request head? For some reason I'm not seeing the runner pick up these edits though

@carllin
Copy link
Contributor

carllin commented Oct 17, 2021

Hmm seems like you actually need to commit the workflow changes to the default branch, i.e. master, before those updates can be picked up for later pull requests: https://github.community/t/workflow-files-only-picked-up-from-master/16129/37

@oJshua
Copy link
Contributor Author

oJshua commented Oct 17, 2021

It is always checking out master before running the formatter?

Good catch. I think it may be!

@carllin
Copy link
Contributor

carllin commented Oct 17, 2021

I think this needs to be merged first: #20750 so that the workflow can be updated, and then we can merge the original fix here #20747

@roederw
Copy link
Contributor

roederw commented Oct 17, 2021

@oJshua You can close this out. @jstarry merged in the formatting changes.

@oJshua oJshua closed this Oct 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants