Bump typenum from 1.14.0 to 1.15.0 to fix SIGILL during build #26471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruuda
changed the title
Version 1.15.0 fixes an issue where code that runs at build-time would be compiled with the target_cpu setting, and the target CPU might support instructions that the host system does not have, causing a SIGILL during the build. See also [1] and [2]. [1]: paholg/typenum#162 [2]: paholg/typenum#177
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Compiling Solana with
-C target-cpumight fail withSIGILLwhen compiling thetypenumdependency.Summary of Changes
Version 1.15.0 fixes an issue where code that runs at build-time would be compiled with the
target_cpusetting, and the target CPU might support instructions that the host system does not have, causing a SIGILL during the build.See also paholg/typenum#162 and paholg/typenum#177.
Changlelog of v1.15.0 shows no other changes relevant for Solana.