optionally allow WEBIRC blocks to spoof ident responses #344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note that authproc does not check whether |
dwfreed
requested changes
Jun 16, 2022
dwfreed
requested changes
Nov 8, 2023
| @@ -419,6 +419,7 @@ struct ListClient | |||
| #define FLAGS_EXEMPTSHIDE 0x04000000 | |||
| #define FLAGS_EXEMPTJUPE 0x08000000 | |||
| #define FLAGS_IDENTIFIED 0x10000000 /* owns their current nick */ | |||
| #define FLAGS_USER_SPOOFING 0x00000080 /* username has already been set, so ignore it in USER */ | |||
| @@ -500,7 +500,7 @@ register_local_user(struct Client *client_p, struct Client *source_p) | |||
| } | |||
|
|
|||
| /* dont replace username if its supposed to be spoofed --fl */ | |||
| if(!IsConfDoSpoofIp(aconf) || !strchr(aconf->info.name, '@')) | |||
| if(!IsUserSpoof(source_p)) | |||
There was a problem hiding this comment.
The above-mentioned collision means that this if is always true
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.