Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make most snotes NETWIDE #93

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Make most snotes NETWIDE #93

wants to merge 2 commits into from

Conversation

dwfreed
Copy link
Member

@dwfreed dwfreed commented Dec 20, 2020

I did look through most of these to make sure they were sane, but a second set of eyes would be good. I didn't touch most snotes for bans (K/D/X lines, RESVs) because I figured we could do those when we rework ban propagation and elimination of clusters and such.

@edk0
Copy link
Contributor

edk0 commented Dec 20, 2020

I'm not thrilled about making things netwide snotes that are propagated globally anyway.

@dwfreed
Copy link
Member Author

dwfreed commented Dec 20, 2020

Connect needs to be netwide, because only the local server knows the connection class; the others that are propagated that previously had a snote extension I'd be open to integrating into the appropriate place. But sno_globaloper was a hack (checks for umode +o), and sno_globalkline is the hackiest of hacks (checks for specific quit messages), so those definitely need to go.

@dwfreed
Copy link
Member Author

dwfreed commented Dec 20, 2020

(The sasl_abort1 test failures are because the connect snotes are now in the server sendq)

@dwfreed dwfreed added this to the OFTC Feature Parity milestone Feb 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants