Simple Governor OZ proposal #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anajuliabit
requested changes
May 24, 2024
src/proposals/simple-vault-governor-oz/GovernorOZProposal_01.sol
Outdated
Show resolved
Hide resolved
src/proposals/simple-vault-governor-oz/GovernorOZProposal_01.sol
Outdated
Show resolved
Hide resolved
src/proposals/simple-vault-governor-oz/GovernorOZProposal_02.sol
Outdated
Show resolved
Hide resolved
src/proposals/simple-vault-governor-oz/GovernorOZProposal_02.sol
Outdated
Show resolved
Hide resolved
script/DeployGovernorBravo.s.sol
Outdated
| super.run(); | ||
| } | ||
|
|
||
| function validate() public override { |
There was a problem hiding this comment.
looks like we can make this function view
There was a problem hiding this comment.
Earlier I was unable to make this function view, it caused compilation error. It got fixed after I updated the forge-std submodule.
script/DeployTimelock.s.sol
Outdated
| super.run(); | ||
| } | ||
|
|
||
| function validate() public override { |
There was a problem hiding this comment.
can we make this function view?
There was a problem hiding this comment.
Earlier I was unable to make this function view, it caused compilation error. It got fixed after I updated the forge-std submodule.
script/InitializeBravo.s.sol
Outdated
| address governor = addresses.getAddress("PROTOCOL_GOVERNOR"); | ||
|
|
||
| address payable timelock = payable( | ||
| addresses.getAddress("PROTOCOL_TIMELOCK_BRAVO") | ||
| ); | ||
|
|
||
| vm.startBroadcast(); | ||
|
|
||
| // Deploy mock GovernorAlpha | ||
| address govAlpha = address(new MockGovernorAlpha()); |
There was a problem hiding this comment.
let's do an isAddressSet check here before we create this new contract
Comment on lines
4
to
8
| import "@openzeppelin/governance/Governor.sol"; | ||
| import "@openzeppelin/governance/extensions/GovernorVotes.sol"; | ||
| import "@openzeppelin/governance/extensions/GovernorCountingSimple.sol"; | ||
| import "@openzeppelin/governance/extensions/GovernorVotesQuorumFraction.sol"; | ||
| import "@openzeppelin/governance/extensions/GovernorTimelockControl.sol"; |
There was a problem hiding this comment.
style: import {ContractName} from ..
Proposal output for src/proposals/simple-vault-bravo/BravoProposal_02.sol: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.