Rename Governor OZ to OZ Governor #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prat-gpt
changed the title
lib/forge-proposal-simulator
Outdated
There was a problem hiding this comment.
is this up to date on the latest version?
There was a problem hiding this comment.
This is currently on the docs branch as the name of GovernorOZProposal has been updated to OZGovernorProposal on FPS. Once docs PR gets merged there I will update this to the main branch. @ElliotFriedman
| address token = addresses.getAddress("GOVERNOR_OZ_VAULT_TOKEN"); | ||
| (uint256 amount, ) = governorOZVault.deposits(address(token), timelock); | ||
| address timelock = addresses.getAddress("OZ_GOVERNOR_TIMELOCK"); | ||
| Vault OZGovernorVault = Vault(addresses.getAddress("OZ_GOVERNOR_VAULT")); |
There was a problem hiding this comment.
naming: OZGovernorVault -> ozGovernorVault
|
|
||
| string memory output = string(vm.ffi(inputs)); | ||
|
|
||
| GovernorOZProposal governorOZproposal = GovernorOZProposal( | ||
| OZGovernorProposal OZGovernorproposal = OZGovernorProposal( |
There was a problem hiding this comment.
camelcase variable name
Comment on lines
12
to
13
| Vault OZGovernorVault = Vault(addresses.getAddress("OZ_GOVERNOR_VAULT")); | ||
| address OZGovernorTimelock = addresses.getAddress("OZ_GOVERNOR_TIMELOCK"); |
Proposal output for src/proposals/simple-vault-governor-oz/OZGovernorProposal_02.sol: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.