Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add JSdoc #495

Merged
merged 3 commits into from
Dec 4, 2024
Merged

Add JSdoc #495

merged 3 commits into from
Dec 4, 2024

Conversation

marvin-j97
Copy link
Contributor

@marvin-j97 marvin-j97 commented Nov 8, 2024

As of now, the IDE experience with Solid Router is subpar because of missing JSdocs. I added JSdocs for most Router functions:

Before

image

After

image

Copy link

changeset-bot bot commented Nov 8, 2024

🦋 Changeset detected

Latest commit: fe5c83e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@solidjs/router Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@ryansolid ryansolid merged commit 3ebc71b into solidjs:main Dec 4, 2024
@ryansolid
Copy link
Member

Looks great. Thank you.

@marvin-j97 marvin-j97 deleted the docs branch December 4, 2024 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants