Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update _form.html.erb #56

Closed
wants to merge 4 commits into from
Closed

Conversation

iqre8
Copy link

@iqre8 iqre8 commented Mar 17, 2021

Prevent people from uploading excel files.
Who is people? We are people....

iqre8 added 2 commits March 17, 2021 08:04
Prevent people from uploading excel files.
Who is people? We are people....
Forgot closing quote
Copy link
Author

@iqre8 iqre8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for missing the closing "

@jarednorman
Copy link
Member

Bad news: Windows machines with Excel installed will sometimes send CSVs with a propriety MIME that will ruin your day, application/vnd.ms-excel. You might be thinking, "wait, that doesn't even say it's a CSV," and sadly, you're right. It doesn't. We've seen this issue with other CSV handling systems. 😒

I'd love to find a good solution for both this issue as well as #55 so that we can be better friends with people using Excel and live in harmony.

iqre8 added 2 commits March 18, 2021 19:04
Help the user at least figure out what type of issues he has with uploading the csv
Removed the check on mime type as this is fixed in solidusio-contrib#58
@kennyadsl
Copy link
Member

@iqre8 what about doing this on the server-side instead?

@iqre8
Copy link
Author

iqre8 commented Apr 14, 2021

@kennyadsl I would prefer it be done on both sides. Client side would reduce the amount of 'errors' caused. And server-side would primarily be needed to stop malicious attempts.
It certainly won't make the app noticable slower on the client side.

@stale
Copy link

stale bot commented Jun 16, 2021

This issue has been automatically marked as stale because it has not had recent activity. It might be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jun 16, 2021
@kennyadsl kennyadsl closed this May 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants