Refactor Line Item Total Calculations #6080
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
changelog:solidus_core
jarednorman
force-pushed
the
refactor-line-item-total-updates
branch
from
c3214bb to
9a82ff7
Compare
|
Hey @jarednorman Do you think also #1837 could be tackled in #5872 . Think what you are doing here will also reduce testing time significantly which is also great. If not we would like to align with you and dedicate some resources to fix #1837 already on your new model. |
|
Ok, when you finished #5872 if you like @shahmayur001 can take a look at #1837 |
adammathys
force-pushed
the
refactor-line-item-total-updates
branch
from
9a82ff7 to
15dac06
Compare
github-actions
bot
added
the
changelog:solidus_legacy_promotions
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6080 +/- ##
==========================================
- Coverage 92.42% 88.70% -3.73%
==========================================
Files 389 830 +441
Lines 8005 17998 +9993
==========================================
+ Hits 7399 15965 +8566
- Misses 606 2033 +1427 ☔ View full report in Codecov by Sentry. |
tvdeyen
reviewed
Jan 31, 2025
While working on the in-memory updater in solidusio#5872, we found the need to change how item totals were being calculated, so that we could mark adjustments for destruction without actually destroying them, while still keeping tax adjustments intact. This change is completely backwards-compatible with the current OrderUpdater, so to reduce the scope of our PR, we wanted to make this change separately. Since the OrderUpdater is already very large, this helps reduce its responsibilities and makes it easier to test this behaviour. We don't see it as necessary to make this a configurable class, but this change leaves that option open in the future. Co-authored-by: Adam Mueller <[email protected]> Co-authored-by: Alistair Norman <[email protected]> Co-authored-by: Chris Todorov <[email protected]> Co-authored-by: Harmony Bouvier <[email protected]> Co-authored-by: Sofia Besenski <[email protected]> Co-authored-by: benjamin wil <[email protected]>
I don't know if there's all that much customizing people will perform on this class, but it's easy enough to make it configurable just in case.
adammathys
force-pushed
the
refactor-line-item-total-updates
branch
from
15dac06 to
7a3bfc2
Compare
|
@kennyadsl can we merge this, it seems to be universally approved. |
kennyadsl
approved these changes
Feb 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is related to #5872, but it is not a functional change. It refactors the existing order updater to use a class that we created for the in-memory order updater. The goal here is just to reduce the scope of that PR, though it's also a small design improvement.
Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs:
The following are not always needed: