Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update envoy-gloo to 1.32.3-patch2 #10595

Merged
merged 11 commits into from
Feb 12, 2025
Merged

Update envoy-gloo to 1.32.3-patch2 #10595

merged 11 commits into from
Feb 12, 2025

Conversation

ashishb-solo
Copy link

@ashishb-solo ashishb-solo commented Jan 31, 2025

Description

Update envoy-gloo dependency to v1.32.3-patch2

API changes

N/A

Code changes

None

CI changes

None

Docs changes

None

Context

Interesting decisions

Testing steps

Notes for reviewers

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

BOT NOTES:
resolves https://github.com/solo-io/solo-projects/issues/7608

Copy link

github-actions bot commented Jan 31, 2025

Visit the preview URL for this PR (updated for commit 6c368f1):

https://gloo-edge--pr10595-envoy-1-32-bump2-mp52gjr2.web.app

(expires Wed, 19 Feb 2025 06:28:40 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 77c2b86e287749579b7ff9cadb81e099042ef677

@solo-changelog-bot
Copy link

Issues linked to changelog:
https://github.com/solo-io/solo-projects/issues/7608

@nfuden
Copy link
Collaborator

nfuden commented Feb 3, 2025

Can we please add something to the changelog for customers to address

http: The default configuration of Envoy will continue to trust internal addresses while in the future it will not trust them by default. If you have tooling such as probes on your private network which need to be treated as trusted (e.g. changing arbitrary x-envoy headers) please explictily include those addresses or CIDR ranges into [internal_address_config](https://www.envoyproxy.io/docs/envoy/v1.32.3/api-v3/extensions/filters/network/http_connection_manager/v3/http_connection_manager.proto.html#envoy-v3-api-field-extensions-filters-network-http-connection-manager-v3-httpconnectionmanager-internal-address-config) See the config examples from the above internal_address_config link. You can turn up or test the upcoming internal address defaults by setting runtime guard envoy.reloadable_features.explicit_internal_address_config to true.

Copy link
Collaborator

@nfuden nfuden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a link to enterprise showing it passing as well so we dont block other developers from updating oss

@ashishb-solo ashishb-solo marked this pull request as draft February 5, 2025 15:25
@ashishb-solo ashishb-solo marked this pull request as ready for review February 10, 2025 18:18
@soloio-bulldozer soloio-bulldozer bot merged commit e1a5574 into main Feb 12, 2025
20 checks passed
@soloio-bulldozer soloio-bulldozer bot deleted the envoy-1.32-bump2 branch February 12, 2025 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants