Skip to content

Commit

Permalink
Merge bitcoin#26546: test: remove unused class NodePongAdd1
Browse files Browse the repository at this point in the history
40bdc8a test: remove unused class `NodePongAdd1` (Sebastian Falbesoner)

Pull request description:

  This class was introduced in commit fa33654 ("net: Use mockable time for ping/pong, add tests"), but actually never used.

ACKs for top commit:
  stickies-v:
    ACK 40bdc8a

Tree-SHA512: b5a6552e4f2e0b7e368a071cc53b9a8e6f5d1950565a9fda8eb1971a01d8be0541d066842723ef44174fe8189925fa36f2defb6d7bf8d104abc77de410cc4c13
  • Loading branch information
fanquake committed Nov 21, 2022
2 parents 0968c51 + 40bdc8a commit 01a66e2
Showing 1 changed file with 2 additions and 8 deletions.
10 changes: 2 additions & 8 deletions test/functional/p2p_ping.py
Original file line number Diff line number Diff line change
Expand Up @@ -12,27 +12,21 @@
from test_framework.test_framework import BitcoinTestFramework
from test_framework.util import assert_equal


PING_INTERVAL = 2 * 60
TIMEOUT_INTERVAL = 20 * 60


class msg_pong_corrupt(msg_pong):
def serialize(self):
return b""


class NodePongAdd1(P2PInterface):
def on_ping(self, message):
self.send_message(msg_pong(message.nonce + 1))


class NodeNoPong(P2PInterface):
def on_ping(self, message):
pass


TIMEOUT_INTERVAL = 20 * 60


class PingPongTest(BitcoinTestFramework):
def set_test_params(self):
self.setup_clean_chain = True
Expand Down

0 comments on commit 01a66e2

Please sign in to comment.