Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BG-332]: ws 접속 정보를 레디스에 기록한다 (4h / 3h) #70

Merged
merged 8 commits into from
Aug 9, 2024

Conversation

Dltmd202
Copy link
Member

@Dltmd202 Dltmd202 commented Aug 7, 2024

Why

웹 소켓 세션을 레디스에 저장하여 다수의 realtime 서버에 특정 소켓을 트래킹할 수 있어야 한다.

Link

BG-332

@Dltmd202 Dltmd202 self-assigned this Aug 7, 2024
@GGHDMS GGHDMS self-requested a review August 7, 2024 05:31
@@ -16,6 +16,7 @@ class RestClientAspect {
try {
jointPoint.proceed()
} catch (e: Exception) {
println(e)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

뭐고

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

헿~

Comment on lines 6 to 13
data class WorkspaceSession
@JsonCreator
constructor(
@JsonProperty("id") val id: String,
@JsonProperty("userId") val userId: String,
@JsonProperty("workspaceId") val workspaceId: Long,
@JsonProperty("realtimeId") val realtimeId: String,
)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JsonCreator 가 여기서 왜 필요해?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이게 원래 레디스에 그대로 저장될 데이터였는데 수정하면서 필요없어진 것 같넹!
삭제할겡!

Copy link
Member

@GGHDMS GGHDMS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@GGHDMS GGHDMS merged commit 82f1bd6 into develop Aug 9, 2024
1 check passed
@GGHDMS GGHDMS deleted the feature/BG-332-register-ws-session-in-redis branch August 9, 2024 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants